support "both" direction for network partition #136
Conversation
Signed-off-by: xiang <xiang13225080@163.com>
Signed-off-by: xiang <xiang13225080@163.com>
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
WangXiangUSTC
changed the title
WangXiangUSTC
requested review from
Andrewmatilde
and removed request for
Yiyiyimu
|
@cwen0 PTAL again |
pkg/core/network.go
Outdated
| if n.Direction == "to" || n.Direction == "both" { | ||
| toChains, err = n.getPartitionChain(ipset, "to") | ||
| if err != nil { | ||
| return nil, errors.WithStack(err) |
There was a problem hiding this comment.
If the error is returned by function inside the Chaos Mesh, we could assume this error is already equipped with a stack backtrace, so there is no need to call errors.WithStack.
There was a problem hiding this comment.
The function getPartitionChain only returns an error when direction is neither to nor from, the error is not from Chaos Mesh
There was a problem hiding this comment.
The error of getPartitionChain was generated by errors.New, which has equipped with a stack backtrace. So we don't need to use 'errors.WithStack` here.
pkg/core/network.go
Outdated
| if n.Direction == "from" || n.Direction == "both" { | ||
| fromChains, err = n.getPartitionChain(ipset, "from") | ||
| if err != nil { | ||
| return nil, errors.WithStack(err) |
|
@cwen0 PTAL again |
Signed-off-by: xiang <xiang13225080@163.com>
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: a9bcb49
|
Now only support direction "from" and "to" for partition, users need to run chaosd command twice if they want to partition both "from" and "to".
This pr close issue #127