Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ignore process not found while recovering the stress #145

Merged
merged 2 commits into from
Mar 28, 2022
Merged

ignore process not found while recovering the stress #145

merged 2 commits into from
Mar 28, 2022

Conversation

YangKeao
Copy link
Member

Signed-off-by: YangKeao yangkeao@chunibyo.icu

If the process is not found, we can assume that it's already been recovered (or killed by other processes, like oom killer).

@YangKeao
fix stress recover
efe1e4f 
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 24, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • WangXiangUSTC
  • iguoyr

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

iguoyr
iguoyr reviewed Mar 24, 2022
View reviewed changes
Copy link
Member

@iguoyr iguoyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

pkg/server/chaosd/stress.go Outdated Show resolved Hide resolved
@YangKeao
fix error assert
7d369a3 
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
Andrewmatilde
Andrewmatilde approved these changes Mar 25, 2022
View reviewed changes
Copy link
Member

@Andrewmatilde Andrewmatilde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

WangXiangUSTC
WangXiangUSTC approved these changes Mar 25, 2022
View reviewed changes
Copy link
Collaborator

@WangXiangUSTC WangXiangUSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WangXiangUSTC
Copy link
Collaborator

/merge

@ti-chi-bot
Copy link
Member

@WangXiangUSTC: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@WangXiangUSTC
Copy link
Collaborator

/merge

@ti-chi-bot
Copy link
Member

@WangXiangUSTC: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

WangXiangUSTC
WangXiangUSTC previously approved these changes Mar 28, 2022
View reviewed changes
iguoyr
iguoyr approved these changes Mar 28, 2022
View reviewed changes
Copy link
Member

@iguoyr iguoyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iguoyr
Copy link
Member

iguoyr commented Mar 28, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 7d369a3

@ti-chi-bot ti-chi-bot merged commit 83893b4 into chaos-mesh:main Mar 28, 2022
@WangXiangUSTC WangXiangUSTC mentioned this pull request May 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WangXiangUSTC WangXiangUSTC WangXiangUSTC approved these changes

@iguoyr iguoyr iguoyr approved these changes

@Andrewmatilde Andrewmatilde Andrewmatilde approved these changes

Assignees
No one assigned
Labels
size/XS status/can-merge status/LGT2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@YangKeao @ti-chi-bot @WangXiangUSTC @iguoyr @Andrewmatilde