Update chaos-mesh version to 20220511035234-10df92fcde77. #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: andrewmatilde <davis6813585853062@outlook.com>
# Conflicts: # go.mod # go.sum
Signed-off-by: andrewmatilde <davis6813585853062@outlook.com>
Signed-off-by: andrewmatilde <davis6813585853062@outlook.com>
Signed-off-by: andrewmatilde <davis6813585853062@outlook.com>
Signed-off-by: andrewmatilde <davis6813585853062@outlook.com>
|
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Signed-off-by: andrewmatilde <davis6813585853062@outlook.com>
|
PTAL @WangXiangUSTC , @cwen0 , @FingerLeader . I plan to just fix clock attack in this PR. |
.github/workflows/release_latest.yml
Outdated
| @@ -11,10 +11,10 @@ jobs: | |||
| # glibc version 2.17 | |||
| container: docker.io/centos:7.2.1511 | |||
| steps: | |||
| - name: Set up Go 1.16 | |||
| - name: Set up Go 1.168 | |||
There was a problem hiding this comment.
Suggested change
| - name: Set up Go 1.168 | |
| - name: Set up Go 1.18 |
.github/workflows/ci.yml
Outdated
| @@ -35,7 +36,7 @@ jobs: | |||
| # workaround for https://github.com/actions/setup-go/issues/14 | |||
| export GOPATH=${GITHUB_WORKSPACE}/go | |||
| export PATH=$PATH:$GOPATH/bin | |||
|
|
|||
There was a problem hiding this comment.
how about cleaning this empty space
| @@ -181,7 +183,7 @@ func (s *Server) applyTC(attack *core.NetworkCommand, ipset string, uid string) | |||
| } | |||
|
|
|||
| tcs = append(tcs, newTC) | |||
| if _, err := s.svr.SetTcs(context.Background(), &pb.TcsRequest{Tcs: tcs, Device: attack.Device, EnterNS: false}); err != nil { | |||
| if _, err := s.svr.SetTcs(context.Background(), &pb.TcsRequest{Tcs: tcs, EnterNS: false}); err != nil { | |||
There was a problem hiding this comment.
how about adding a TODO here
Signed-off-by: andrewmatilde <davis6813585853062@outlook.com>
|
@FingerLeader: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Signed-off-by: andrewmatilde <davis6813585853062@outlook.com>
Signed-off-by: andrewmatilde <davis6813585853062@outlook.com>
Signed-off-by: andrewmatilde <davis6813585853062@outlook.com>
|
LGTM |
ti-chi-bot
pushed a commit
that referenced
this pull request
Jul 20, 2022
* Update chaos-mesh version to 20220511035234-10df92fcde77. (#161) * update chaos-mesh version Signed-off-by: andrewmatilde <davis6813585853062@outlook.com> * update go.mod&go.sum Signed-off-by: andrewmatilde <davis6813585853062@outlook.com> * update go version of workflow Signed-off-by: andrewmatilde <davis6813585853062@outlook.com> * fix lint Signed-off-by: andrewmatilde <davis6813585853062@outlook.com> * install go imports in ci Signed-off-by: andrewmatilde <davis6813585853062@outlook.com> * replace go get with go install in makefile Signed-off-by: andrewmatilde <davis6813585853062@outlook.com> * make fmt Signed-off-by: andrewmatilde <davis6813585853062@outlook.com> * add ci to branch update Signed-off-by: andrewmatilde <davis6813585853062@outlook.com> * fix comment Signed-off-by: andrewmatilde <davis6813585853062@outlook.com> * revert changes: clock.go Signed-off-by: andrewmatilde <davis6813585853062@outlook.com> * update to golang 1.18 Signed-off-by: andrewmatilde <davis6813585853062@outlook.com> * fix bug :Provide server don't have (prometheus.Registerer, logr.Logger) Signed-off-by: andrewmatilde <davis6813585853062@outlook.com> * make fmt Signed-off-by: andrewmatilde <davis6813585853062@outlook.com> * make fmt Signed-off-by: andrewmatilde <davis6813585853062@outlook.com> * support HTTP Attack on chaosd (#165) * update chaos-mesh version Signed-off-by: andrewmatilde <davis6813585853062@outlook.com> * update go.mod&go.sum Signed-off-by: andrewmatilde <davis6813585853062@outlook.com> * update go version of workflow Signed-off-by: andrewmatilde <davis6813585853062@outlook.com> * fix lint Signed-off-by: andrewmatilde <davis6813585853062@outlook.com> * install go imports in ci Signed-off-by: andrewmatilde <davis6813585853062@outlook.com> * replace go get with go install in makefile Signed-off-by: andrewmatilde <davis6813585853062@outlook.com> * make fmt Signed-off-by: andrewmatilde <davis6813585853062@outlook.com> * add ci to branch update Signed-off-by: andrewmatilde <davis6813585853062@outlook.com> * fix comment Signed-off-by: andrewmatilde <davis6813585853062@outlook.com> * revert changes: clock.go Signed-off-by: andrewmatilde <davis6813585853062@outlook.com> * add part of http support Signed-off-by: andrewmatilde <davis6813585853062@outlook.com> * update to golang 1.18 Signed-off-by: andrewmatilde <davis6813585853062@outlook.com> * fix bug :Provide server don't have (prometheus.Registerer, logr.Logger) Signed-off-by: andrewmatilde <davis6813585853062@outlook.com> * complete part of http attack Signed-off-by: andrewmatilde <davis6813585853062@outlook.com> * make fmt Signed-off-by: andrewmatilde <davis6813585853062@outlook.com> * make fmt Signed-off-by: andrewmatilde <davis6813585853062@outlook.com> * chaos Signed-off-by: andrewmatilde <davis6813585853062@outlook.com> * fix some bug Signed-off-by: andrewmatilde <davis6813585853062@outlook.com> * add recover Signed-off-by: andrewmatilde <davis6813585853062@outlook.com> * try fix recover bug Signed-off-by: andrewmatilde <davis6813585853062@outlook.com> * try fix recover bug Signed-off-by: andrewmatilde <davis6813585853062@outlook.com> * sig kill -> sig term Signed-off-by: andrewmatilde <davis6813585853062@outlook.com> * fix lint Signed-off-by: andrewmatilde <davis6813585853062@outlook.com> * add server side Signed-off-by: andrewmatilde <davis6813585853062@outlook.com> * make logger instead of fmt.Printf Signed-off-by: andrewmatilde <davis6813585853062@outlook.com> * make logger instead of fmt.Printf Signed-off-by: andrewmatilde <davis6813585853062@outlook.com> * fix typo Mathc -> Match Signed-off-by: andrewmatilde <davis6813585853062@outlook.com> * fix type AttackHTTP -> HTTPAttack Signed-off-by: andrewmatilde <davis6813585853062@outlook.com> * rules -> rule Signed-off-by: andrewmatilde <davis6813585853062@outlook.com> * tion Signed-off-by: andrewmatilde <davis6813585853062@outlook.com> * errors.Errorf(string) -> errors.New Signed-off-by: andrewmatilde <davis6813585853062@outlook.com> * fix typo:space Signed-off-by: andrewmatilde <davis6813585853062@outlook.com> * fix typo:proxy_ports Signed-off-by: andrewmatilde <davis6813585853062@outlook.com> * add comment for pkg/server/chaosd/http.go:L97 Signed-off-by: andrewmatilde <davis6813585853062@outlook.com> * fix description Signed-off-by: andrewmatilde <davis6813585853062@outlook.com> * abort HTTP Package -> HTTP connection Signed-off-by: andrewmatilde <davis6813585853062@outlook.com> * New type Signed-off-by: andrewmatilde <davis6813585853062@outlook.com> * minor fix BUG in http chaos config action (#182) Signed-off-by: andrewmatilde <davis6813585853062@outlook.com> * HTTP attack: support send HTTP request (#177) * add http request Signed-off-by: xiang <xiang13225080@163.com> * update description Signed-off-by: xiang <xiang13225080@163.com> * fix stress ci Signed-off-by: FingerLeader <wanxfinger@gmail.com> * use memStress to implement mem attack Signed-off-by: FingerLeader <wanxfinger@gmail.com> * update mem attack test Signed-off-by: FingerLeader <wanxfinger@gmail.com> * update ci Signed-off-by: FingerLeader <wanxfinger@gmail.com> * fix tcsRequest Signed-off-by: FingerLeader <wanxfinger@gmail.com> * fix ci Signed-off-by: FingerLeader <wanxfinger@gmail.com> * fix ci Signed-off-by: FingerLeader <wanxfinger@gmail.com> * bump chaos-mesh pkg Signed-off-by: FingerLeader <wanxfinger@gmail.com> * edit some details Signed-off-by: FingerLeader <wanxfinger@gmail.com> Co-authored-by: Andrewmatilde <davis6813585853062@outlook.com> Co-authored-by: WangXiang <xiang13225080@163.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update chaos-mesh version to 20220511035234-10df92fcde77.
Update golang version to 1.18
Issue: #162
I have also fixed clock attack on building in this PR. I will merge changes from chaos-mesh/pkg/time later.
Signed-off-by: andrewmatilde davis6813585853062@outlook.com