redisChaos: add cache limit #163
Conversation
Signed-off-by: FingerLeader <wanxfinger@gmail.com>
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Signed-off-by: FingerLeader <wanxfinger@gmail.com>
Signed-off-by: FingerLeader <wanxfinger@gmail.com>
pkg/server/chaosd/redis.go
Outdated
| @@ -73,9 +108,23 @@ func (redisAttack) Recover(exp core.Experiment, env Environment) error { | |||
| } | |||
| attack := config.(*core.RedisCommand) | |||
|
|
|||
| cli := redis.NewClient(&redis.Options{ | |||
There was a problem hiding this comment.
If the action is core.RedisSentinelStopAction, this logic is useless. So we should add it to option core.RedisCacheLimitAction: logic.
Signed-off-by: FingerLeader <wanxfinger@gmail.com>
|
@FingerLeader CI broken! Please fix it! |
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 6dffb7c
|
Signed-off-by: FingerLeader wanxfinger@gmail.com