Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kafka io attack: add username and password flags #231

Merged
merged 2 commits into from
Jan 29, 2023

Conversation

cwen0
Copy link
Member

@cwen0 cwen0 commented Jan 29, 2023

Signed-off-by: cwen0 cwenyin0@gmail.com

add username and password flags to fix this
image

Chaosd will access Kafka server to get partitions when to exec io attack. So username, password, host, and port should be supported.

func findPartitionDirs(attack *core.KafkaCommand, logDirs []string) ([]string, error) {
partitions, err := getPartitions(attack)
if err != nil {

Signed-off-by: cwen0 <cwenyin0@gmail.com>
@cwen0 cwen0 requested a review from Hexilee January 29, 2023 08:38
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 29, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • iguoyr

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

Signed-off-by: cwen0 <cwenyin0@gmail.com>
@cwen0 cwen0 changed the title add username and password flags kafka io attack: add username and password flags Jan 29, 2023
Copy link
Member

@iguoyr iguoyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cwen0
Copy link
Member Author

cwen0 commented Jan 29, 2023

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 9bcf11d

@ti-chi-bot ti-chi-bot merged commit 31631c3 into chaos-mesh:main Jan 29, 2023
@cwen0 cwen0 deleted the fix-kakfa-attack branch January 29, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants