Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue about disk attack cannot work well in chaos-mesh:physical machine chaos #236

Merged
merged 27 commits into from
Feb 8, 2023

Conversation

Andrewmatilde
Copy link
Member

Add a command pool to orgnize sub commands.
Make disk chaos in server side runs asynchronously.

Signed-off-by: andrewmatilde <davis6813585853062@outlook.com>
Signed-off-by: andrewmatilde <davis6813585853062@outlook.com>
Signed-off-by: andrewmatilde <davis6813585853062@outlook.com>
Signed-off-by: andrewmatilde <davis6813585853062@outlook.com>
Signed-off-by: andrewmatilde <davis6813585853062@outlook.com>
Signed-off-by: andrewmatilde <davis6813585853062@outlook.com>
Signed-off-by: andrewmatilde <davis6813585853062@outlook.com>
Signed-off-by: andrewmatilde <davis6813585853062@outlook.com>
…ted function

Signed-off-by: andrewmatilde <davis6813585853062@outlook.com>
Signed-off-by: andrewmatilde <davis6813585853062@outlook.com>
Signed-off-by: andrewmatilde <davis6813585853062@outlook.com>
Signed-off-by: andrewmatilde <davis6813585853062@outlook.com>
Signed-off-by: andrewmatilde <davis6813585853062@outlook.com>
Signed-off-by: andrewmatilde <davis6813585853062@outlook.com>
Signed-off-by: andrewmatilde <davis6813585853062@outlook.com>
Signed-off-by: andrewmatilde <davis6813585853062@outlook.com>
Signed-off-by: andrewmatilde <davis6813585853062@outlook.com>
Signed-off-by: andrewmatilde <davis6813585853062@outlook.com>
Signed-off-by: andrewmatilde <davis6813585853062@outlook.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 8, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • cwen0

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

Signed-off-by: andrewmatilde <davis6813585853062@outlook.com>
@Andrewmatilde
Copy link
Member Author

PTAL @cwen0 .

Copy link
Member

@cwen0 cwen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Andrewmatilde
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

@Andrewmatilde: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@Andrewmatilde
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 43c4711

@Andrewmatilde Andrewmatilde merged commit 19a1572 into chaos-mesh:main Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants