JVM attack: combine install and submit into one #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xiang <xiang13225080@163.com>
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
Signed-off-by: xiang <xiang13225080@163.com>
Signed-off-by: xiang <xiang13225080@163.com>
fewdan
requested changes
Sep 17, 2021
Signed-off-by: xiang <xiang13225080@163.com>
Signed-off-by: xiang <xiang13225080@163.com>
Signed-off-by: xiang <xiang13225080@163.com>
WangXiangUSTC
force-pushed
the
jvm_refine
branch
from
2c850ef
to
4af0e85
Compare
| // TODO: Investigate the cause of these two error | ||
| errMsg2 := "Provider sun.tools.attach.LinuxAttachProvider not found" | ||
| errMsg3 := "install java.io.IOException: Non-numeric value found" | ||
| if !strings.Contains(string(output), errMsg1) && !strings.Contains(string(output), errMsg2) && |
There was a problem hiding this comment.
Since errMsgX are all only used once here , I think giving the literal string is enough.
There was a problem hiding this comment.
It's convenient to add comments, and avoid lines that are too long
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: xiang xiang13225080@163.com
combine install and submit into one, to make it easy to create JVM chaos in dashboard