Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: workflow status on dashboard #190

Merged
merged 5 commits into from
Dec 16, 2021
Merged

docs: workflow status on dashboard #190

merged 5 commits into from
Dec 16, 2021

Conversation

STRRL
Copy link
Member

@STRRL STRRL commented Dec 9, 2021

Signed-off-by: STRRL str_ruiling@outlook.com

@STRRL
docs: workflow status on dashboard
8c0352e 
Signed-off-by: STRRL <str_ruiling@outlook.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 9, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • en-jin19

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the do-not-merge/blocked-paths Indicates that a PR should not merge because it touches files in blocked paths. label Dec 9, 2021
@ti-chi-bot
Copy link
Member

@STRRL: Adding label: do-not-merge/blocked-paths because PR changes a protected file.

Reasons for blocking this PR:

[This PR modifies the files under the docs folder and requires the docs team to follow up on the PR.

/label docs
]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added docs size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 9, 2021
@STRRL STRRL mentioned this pull request Dec 9, 2021
Closed
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 13, 2021
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 13, 2021
@en-jin19
Copy link
Contributor

@STRRL could you please invite a tech reviewer? thanks!

@STRRL @en-jin19
Apply suggestions from code review
7d679e1 
Co-authored-by: Enwei <jinenwei@pingcap.com>
Signed-off-by: STRRL <str_ruiling@outlook.com>
@STRRL STRRL force-pushed the check-workflow-status-on-dashboard branch from b0a414c to 7d679e1 Compare December 14, 2021 07:39
@STRRL
Copy link
Member Author

STRRL commented Dec 14, 2021

@STRRL could you please invite a tech reviewer? thanks!

Updated PTAL

@STRRL
Copy link
Member Author

STRRL commented Dec 14, 2021

PTAL

/cc @g1eny0ung @cwen0

en-jin19
en-jin19 approved these changes Dec 14, 2021
View reviewed changes
Copy link
Contributor

@en-jin19 en-jin19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 14, 2021
@cwen0
Copy link
Member

cwen0 commented Dec 14, 2021

@STRRL CI was broken! Can you fix it?

@STRRL STRRL force-pushed the check-workflow-status-on-dashboard branch from 6207786 to 7d679e1 Compare December 15, 2021 04:01
@STRRL
chore: upload missing images
90877d5 
Signed-off-by: STRRL <str_ruiling@outlook.com>
@netlify
Copy link

netlify bot commented Dec 15, 2021

✔️ Deploy Preview for chaos-mesh-website-preview ready!

🔨 Explore the source changes: 90877d5

🔍 Inspect the deploy log: https://app.netlify.com/sites/chaos-mesh-website-preview/deploys/61b968c43a9e8a00072bbd0c

😎 Browse the preview: https://deploy-preview-190--chaos-mesh-website-preview.netlify.app

@STRRL
Copy link
Member Author

STRRL commented Dec 15, 2021

@STRRL CI was broken! Can you fix it?

Updated! PTAL!

cwen0
cwen0 approved these changes Dec 16, 2021
View reviewed changes
Copy link
Member

@cwen0 cwen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cwen0
Copy link
Member

cwen0 commented Dec 16, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 90877d5

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 16, 2021
@cwen0 cwen0 merged commit 28706ac into chaos-mesh:master Dec 16, 2021
@en-jin19 en-jin19 added the documentation Additions or improvements to documentation label Mar 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwen0 cwen0 cwen0 approved these changes

@en-jin19 en-jin19 en-jin19 approved these changes

@g1eny0ung g1eny0ung Awaiting requested review from g1eny0ung

Assignees
No one assigned
Labels
do-not-merge/blocked-paths Indicates that a PR should not merge because it touches files in blocked paths. documentation Additions or improvements to documentation size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@STRRL @ti-chi-bot @en-jin19 @cwen0 @g1eny0ung