Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the usage of PickVersion in offline installation #302

Merged

Conversation

STRRL
Copy link
Member

@STRRL STRRL commented May 26, 2022

Signed-off-by: STRRL im@strrl.dev

It's a part of #301

Signed-off-by: STRRL <im@strrl.dev>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 26, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • g1eny0ung

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the do-not-merge/blocked-paths Indicates that a PR should not merge because it touches files in blocked paths. label May 26, 2022
@ti-chi-bot
Copy link
Member

@STRRL: Adding label: do-not-merge/blocked-paths because PR changes a protected file.

Reasons for blocking this PR:

[This PR modifies the files under the docs or versioned_docs folder and requires the docs team to follow up on the PR.

/label documentation
]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added documentation Additions or improvements to documentation size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 26, 2022
@STRRL
Copy link
Member Author

STRRL commented May 26, 2022

Hi @g1eny0ung PTAL

@STRRL STRRL added this to the Release 2.2 milestone May 26, 2022
@netlify
Copy link

netlify bot commented May 26, 2022

Deploy Preview for chaos-mesh-website-preview ready!

Name Link
🔨 Latest commit 62cc17a
🔍 Latest deploy log https://app.netlify.com/sites/chaos-mesh-website-preview/deploys/628f1da739e0ec0008a6463f
😎 Deploy Preview https://deploy-preview-302--chaos-mesh-website-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

src/components/PickVersion.jsx Outdated Show resolved Hide resolved
Signed-off-by: STRRL <im@strrl.dev>
Copy link
Member

@g1eny0ung g1eny0ung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 26, 2022
@STRRL
Copy link
Member Author

STRRL commented May 26, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 62cc17a

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 26, 2022
@STRRL STRRL removed the do-not-merge/blocked-paths Indicates that a PR should not merge because it touches files in blocked paths. label May 26, 2022
@ti-chi-bot ti-chi-bot merged commit 8b2f667 into chaos-mesh:master May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Additions or improvements to documentation size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants