Skip to content

Commit

Permalink
Rename all Sharp files using Fluid Dynamics prefix (#1231)
Browse files Browse the repository at this point in the history
Description
This PR changes the name of the main class and the name of the files related to the lethe-fluid-sharp application. Is the fifth PR of a series of PRs that aim to rename all the Navier Stokes solvers of Lethe using the prefix FluidDynamics and removing GLS.

Testing
All the existent tests pass without any change.
  • Loading branch information
lpsaavedra committed Aug 7, 2024
1 parent 93f8a8d commit d5f50a7
Show file tree
Hide file tree
Showing 8 changed files with 55 additions and 54 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/).

### Changed

- MINOR Renamed the main file related to the `lethe-fluid-sharp` application: `gls_sharp_navier_stokes` to `fluid_dynamics_sharp`. The name of the `GLSSharpNavierStokesSolver` class was changed to `FluidDynamicsSharp`. [#1231](https://github.com/chaos-polymtl/lethe/pull/1231)

### Changed

- MINOR Renamed the main file related to the `lethe-fluid-nitsche` application: `gls_nitsche_navier_stokes` to `fluid_dynamics_nitsche`. The name of the `GLSNitscheNavierStokesSolver` class was changed to `FluidDynamicsNitsche`. [#1228](https://github.com/chaos-polymtl/lethe/pull/1228)

## [Master] - 2024-08-06
Expand Down
2 changes: 1 addition & 1 deletion applications/lethe-fluid-sharp/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
add_executable(lethe-fluid-sharp gls_sharp_navier_stokes.cc)
add_executable(lethe-fluid-sharp fluid_dynamics_sharp.cc)
deal_ii_setup_target(lethe-fluid-sharp)
target_link_libraries(lethe-fluid-sharp lethe-fem-dem)
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
* ---------------------------------------------------------------------
*/

#include "fem-dem/gls_sharp_navier_stokes.h"
#include "fem-dem/fluid_dynamics_sharp.h"

int
main(int argc, char *argv[])
Expand Down Expand Up @@ -42,7 +42,7 @@ main(int argc, char *argv[])
prm.parse_input(argv[1]);
NSparam.parse(prm);

GLSSharpNavierStokesSolver<2> problem(NSparam);
FluidDynamicsSharp<2> problem(NSparam);
problem.solve();
}

Expand All @@ -55,7 +55,7 @@ main(int argc, char *argv[])
prm.parse_input(argv[1]);
NSparam.parse(prm);

GLSSharpNavierStokesSolver<3> problem(NSparam);
FluidDynamicsSharp<3> problem(NSparam);
problem.solve();
}

Expand Down
2 changes: 1 addition & 1 deletion doc/doxygen/main.h
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
auxiliary_physics:e -> auxiliary_physics_4:w [dir=back];
navier_stokes_base_1_1 [label=<<B>FluidDynamicsVANS</B> <br/>(lethe-fluid-vans)>,href="https://chaos-polymtl.github.io/lethe/doxygen/classFluidDynamicsVANS.html", tooltip="FluidDynamicsVANS"];
navier_stokes_base_1_2 [label=<<B>GLSSharpNavierStokesSolver</B> <br/>(lethe-fluid-sharp)>,href="https://chaos-polymtl.github.io/lethe/doxygen/classGLSSharpNavierStokesSolver.html", tooltip="GLSSharpNavierStokesSolver"];
navier_stokes_base_1_2 [label=<<B>FluidDynamicsSharp</B> <br/>(lethe-fluid-sharp)>,href="https://chaos-polymtl.github.io/lethe/doxygen/classFluidDynamicsSharp.html", tooltip="FluidDynamicsSharp"];
navier_stokes_base_1_3 [label=<<B>FluidDynamicsNitsche</B> <br/>(lethe-fluid-nitsche)>,href="https://chaos-polymtl.github.io/lethe/doxygen/classFluidDynamicsNitsche.html", tooltip="FluidDynamicsNitsche"];
navier_stokes_base_1:e -> navier_stokes_base_1_1:w [dir=back];
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,12 +43,12 @@ using namespace dealii;
*/

template <int dim>
class GLSSharpNavierStokesSolver : public GLSNavierStokesSolver<dim>
class FluidDynamicsSharp : public GLSNavierStokesSolver<dim>
{
public:
GLSSharpNavierStokesSolver(CFDDEMSimulationParameters<dim> &nsparam);
FluidDynamicsSharp(CFDDEMSimulationParameters<dim> &nsparam);

~GLSSharpNavierStokesSolver();
~FluidDynamicsSharp();

void
solve() override;
Expand Down
2 changes: 1 addition & 1 deletion include/fem-dem/ib_particles_dem.h
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ using namespace dealii;

/**
* @brief A solver class for the DEM used in conjunction with IB particles and
* gls_sharp_navier_stokes. This class defines and uses some functions of the
* fluid_dynamics_sharp. This class defines and uses some functions of the
* DEM class that have been modified and simplified to be compatible with
* IB_particles.
*
Expand Down
4 changes: 2 additions & 2 deletions source/fem-dem/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ add_library(lethe-fem-dem
# Sources
cfd_dem_coupling.cc
cfd_dem_simulation_parameters.cc
gls_sharp_navier_stokes.cc
fluid_dynamics_sharp.cc
fluid_dynamics_vans.cc
ib_particles_dem.cc
parameters_cfd_dem.cc
Expand All @@ -11,7 +11,7 @@ add_library(lethe-fem-dem
# Headers
../../include/fem-dem/cfd_dem_coupling.h
../../include/fem-dem/cfd_dem_simulation_parameters.h
../../include/fem-dem/gls_sharp_navier_stokes.h
../../include/fem-dem/fluid_dynamics_sharp.h
../../include/fem-dem/fluid_dynamics_vans.h
../../include/fem-dem/ib_particles_dem.h
../../include/fem-dem/parameters_cfd_dem.h
Expand Down
Loading

0 comments on commit d5f50a7

Please sign in to comment.