Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some tables are not checkpointed #916

Closed
14 tasks done
AmishgaAlphonius opened this issue Oct 25, 2023 · 2 comments · Fixed by #938
Closed
14 tasks done

Some tables are not checkpointed #916

AmishgaAlphonius opened this issue Oct 25, 2023 · 2 comments · Fixed by #938
Assignees
@AmishgaAlphonius

Comments

@AmishgaAlphonius
Copy link
Collaborator

AmishgaAlphonius commented Oct 25, 2023 •
edited
Loading

Tables appearing in the finish_simulation() function are not checkpointed.
The tables in their respective physics that need to be checkpointed are listed below.

  1. FD:

    • Forces
    • Torques
    • Errors

  2. Heat Transfert:

    • Errors
    • Heat flux (postprocessing)
    • Statistics table (postprocessing)

  3. Tracer:

    • Errors
    • Statistics table (postprocessing)

  4. VOF:

    • Conservation monitoring
    • Errors
    • Barycenter (postprocessing)

  5. Cahn Hilliard:

    • Errors
    • Statistics table (postprocessing)
  • Update restart tests with the new serialized tables
@AmishgaAlphonius AmishgaAlphonius self-assigned this Nov 25, 2023
@blaisb
Copy link
Contributor

blaisb commented Nov 26, 2023 •
edited
Loading

@AmishgaAlphonius you take care of it or i take care of it? There are some pretty chill helper functions taht can help you with that

@AmishgaAlphonius
Copy link
Collaborator Author

@AmishgaAlphonius you take care of it or i take care of it? There are some pretty chill helper functions taht can help you with that

I can take care of it! I think I found them in utilities.h! It's just that I lost my anydesk connection midway 😅

@AmishgaAlphonius AmishgaAlphonius mentioned this issue Nov 27, 2023
Merged
3 tasks
@AmishgaAlphonius AmishgaAlphonius linked a pull request Nov 27, 2023 that will close this issue
Checkpoint missing tables #938
Merged
3 tasks
blaisb added a commit that referenced this issue Nov 28, 2023
@AmishgaAlphonius @blaisb @oguevremont
Checkpoint missing tables (#938)
cda8dbc 
Description of the problem
A few tables were omitted from being "checkpointed" causing a lost of valuable information when simulations were restarted (Issue: Some tables are not checkpointed #916).
Description of the solution
The missing tables have been added to the write_checkpoint() and read_checkpoint() of each physic.
How Has This Been Tested?
CI
Restart application-tests were updated:
 applications_tests/lethe-fluid/cavity_ht_average_velocity_restart
 applications_tests/lethe-fluid/mms-transient-conduction-restart_gls
 applications_tests/lethe-fluid/taylor-green-vortex-restart_gls_bdf1
Documentation
A small correction was made to doc/source/parameters/cfd/restart.rst

Co-authored-by: Bruno Blais <blais.bruno@gmail.com>
Co-authored-by: Olivier Guévremont <guevremont.o@gmail.com>


Co-authored-by: Bruno Blais <blais.bruno@gmail.com>
Co-authored-by: Olivier Guévremont <guevremont.o@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AmishgaAlphonius AmishgaAlphonius

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Checkpoint missing tables chaos-polymtl/lethe
2 participants
@blaisb @AmishgaAlphonius