Use the eigenvalue estimation of PreconditionRelaxation #1064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterrum
approved these changes
Mar 13, 2024
blaisb
approved these changes
Mar 13, 2024
There was a problem hiding this comment.
Wow I love this, this is so much cleaner and easier to read now.
@lpsaavedra Could you add a changelog entry?
|
I guess we need to drop deal.II 9.5 CI? |
|
I will check the deal.II version as we did here: https://github.com/lethe-cfd/lethe/blob/82095bab9286844d9f1cec0dab67cf3575c1791a/source/solvers/mf_navier_stokes.cc#L651 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the problem
The eigenvalue estimation for the smoother of the multigrid preconditioners was done through a
PreconditionChebyshev.Description of the solution
Due to recent changes in deal.II (dealii/dealii#16742), now we are able to do it using the
PreconditionRelaxationdirectly. This allows us to remove the estimate omega function since it is done internally by the smoother if the relaxation parameter is set to 1. This allows also to remove thedegreeparameter that was only used in the case of Chebyshev.