Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the example on turbulent taylor-couette flow #1083

Merged
merged 8 commits into from
Apr 4, 2024
Merged

Add the example on turbulent taylor-couette flow #1083

merged 8 commits into from
Apr 4, 2024

Conversation

blaisb
Copy link
Contributor

@blaisb blaisb commented Mar 31, 2024

Description of the problem

  • Using the Matrix Free solver, Joel cooked up a very cool 3d Taylor-Couette example that really showcases the power of the matrix free approach

Description of the solution

  • To keep this example for the future, we add it as an example test case.

How Has This Been Tested?

  • Runs well, this is super chill.

@blaisb blaisb force-pushed the example_turb_taylor_couette branch 2 times, most recently from 8975172 to 873a515 Compare April 1, 2024 04:37
PierreLaurentinCS
PierreLaurentinCS requested changes Apr 1, 2024
View reviewed changes
Copy link
Collaborator

@PierreLaurentinCS PierreLaurentinCS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool example featuring the power of matrix-free Lethe. I've put minor comments here and there but overall it's a very good job!

...rce/examples/incompressible-flow/3d-turbulent-taylor-couette/3d-turbulent-taylor-couette.rst Outdated Show resolved Hide resolved
...rce/examples/incompressible-flow/3d-turbulent-taylor-couette/3d-turbulent-taylor-couette.rst Outdated Show resolved Hide resolved
...rce/examples/incompressible-flow/3d-turbulent-taylor-couette/3d-turbulent-taylor-couette.rst Outdated Show resolved Hide resolved
...rce/examples/incompressible-flow/3d-turbulent-taylor-couette/3d-turbulent-taylor-couette.rst
Comment on lines +81 to +83
.. math::
\mathcal{E} &= \frac{1}{\Omega} \int_{\Omega} \frac{\mathbf{\omega}\cdot \mathbf{\omega}}{2} \mathrm{d}\Omega \\
E_k &= \frac{1}{\Omega} \int_{\Omega} \frac{\mathbf{u}\cdot \mathbf{u}}{2} \mathrm{d}\Omega \\
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not to be picky, but it is not homogeneous to an energy per se, is it possible to clarify what energies we are talking about (if it's a specific energy created for turbulent flows for example)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I understand, it's the kinetic energy per unit of mass and volume. It's the definition we use in the regular Lethe doc which I agree is maybe not the most adequate. If we change that I'd change it in another PR however.

...rce/examples/incompressible-flow/3d-turbulent-taylor-couette/3d-turbulent-taylor-couette.rst Outdated Show resolved Hide resolved
examples/incompressible-flow/3d-turbulent-taylor-couette/tc-matrix-free.prm Outdated Show resolved Hide resolved
examples/incompressible-flow/3d-turbulent-taylor-couette/tc-matrix-free.prm Outdated Show resolved Hide resolved
examples/incompressible-flow/3d-turbulent-taylor-couette/tc-matrix-free.prm Outdated Show resolved Hide resolved
examples/incompressible-flow/3d-turbulent-taylor-couette/tc-postprocessing.py Outdated Show resolved Hide resolved
examples/incompressible-flow/3d-turbulent-taylor-couette/tc-postprocessing.py Outdated Show resolved Hide resolved
lpsaavedra
lpsaavedra approved these changes Apr 2, 2024
View reviewed changes
Copy link
Collaborator

@lpsaavedra lpsaavedra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great example! I found it clear and easy to read, and the video is a nice plus!

...rce/examples/incompressible-flow/3d-turbulent-taylor-couette/3d-turbulent-taylor-couette.rst Outdated Show resolved Hide resolved
...rce/examples/incompressible-flow/3d-turbulent-taylor-couette/3d-turbulent-taylor-couette.rst Outdated Show resolved Hide resolved
...rce/examples/incompressible-flow/3d-turbulent-taylor-couette/3d-turbulent-taylor-couette.rst Outdated Show resolved Hide resolved
...rce/examples/incompressible-flow/3d-turbulent-taylor-couette/3d-turbulent-taylor-couette.rst Outdated

.. note::

The mesh resolution used in the case study consists of 20 radial elements, 80 azimuthal elements, and 64 axial elements totalling 102,400 elements. Additionally, it incorporates a mesh refinement near both walls in the radial direction.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last sentence here is not clear to me... is it referring to the local refinement near walls that we did not use? Aren't all the results here using global refinement?

...rce/examples/incompressible-flow/3d-turbulent-taylor-couette/3d-turbulent-taylor-couette.rst
Other Subsections
~~~~~~~~~~~~~~~~~~~~~~~~

The ``non-linear solver`` and ``linear solver`` subsections use the same parameters as the `Taylor-Green Vortex <https://lethe-cfd.github.io/lethe/documentation/examples/incompressible-flow/3d-taylor-green-vortex/3d-taylor-green-vortex.html>`_ example. More details can be found in this example and a complete overview of the ``lethe-fluid-matrix-free`` linear solver can be found in the **Theory Guide** (under construction).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have this overview of the MG methods in my TODO list...

@blaisb
Copy link
Contributor Author

blaisb commented Apr 3, 2024

I applied all of your comments @PierreLaurentinCS so if you are ok with it I will merge

PierreLaurentinCS
PierreLaurentinCS approved these changes Apr 3, 2024
View reviewed changes
Copy link
Collaborator

@PierreLaurentinCS PierreLaurentinCS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good !

blaisb and others added 7 commits April 4, 2024 10:01
@blaisb
Add 3d turbulent taylor couette example
f4e9c67
@blaisb
Fix some naming path
279483b
@blaisb
Fix PRM and update rst
3d48e35
@blaisb @PierreLaurentinCS
Apply suggestions from code review
ea49588 
Co-authored-by: Pierre Laurentin <81017102+PierreLaurentinCS@users.noreply.github.com>
@blaisb @PierreLaurentinCS
Apply suggestions from code review
c06a0ee 
Co-authored-by: Pierre Laurentin <81017102+PierreLaurentinCS@users.noreply.github.com>
@blaisb
Update python script and images
9cc3452
@blaisb @lpsaavedra
Apply suggestions from code review
70f1423 
Co-authored-by: Laura Prieto Saavedra <40216050+lpsaavedra@users.noreply.github.com>
@blaisb blaisb force-pushed the example_turb_taylor_couette branch from d0bb451 to 70f1423 Compare April 4, 2024 08:01
@blaisb blaisb merged commit 95dbbc5 into master Apr 4, 2024
8 checks passed
@blaisb blaisb deleted the example_turb_taylor_couette branch April 4, 2024 08:52
M-Badri pushed a commit to M-Badri/lethe that referenced this pull request Sep 29, 2024
@blaisb @PierreLaurentinCS @lpsaavedra
Add the example on turbulent taylor-couette flow (chaos-polymtl#1083)
2f1aed0 
Description of the problem
Using the Matrix Free solver, Joel cooked up a very cool 3d Taylor-Couette example that really showcases the power of the matrix free approach
Description of the solution
To keep this example for the future, we add it as an example test case.


Co-authored-by: Pierre Laurentin <81017102+PierreLaurentinCS@users.noreply.github.com>
Co-authored-by: Laura Prieto Saavedra <40216050+lpsaavedra@users.noreply.github.com>
Former-commit-id: 95dbbc5
blaisb added a commit that referenced this pull request Sep 30, 2024
@blaisb @PierreLaurentinCS @lpsaavedra
Add the example on turbulent taylor-couette flow (#1083)
68de191 
Description of the problem
Using the Matrix Free solver, Joel cooked up a very cool 3d Taylor-Couette example that really showcases the power of the matrix free approach
Description of the solution
To keep this example for the future, we add it as an example test case.


Co-authored-by: Pierre Laurentin <81017102+PierreLaurentinCS@users.noreply.github.com>
Co-authored-by: Laura Prieto Saavedra <40216050+lpsaavedra@users.noreply.github.com>
Former-commit-id: 95dbbc5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpsaavedra lpsaavedra lpsaavedra approved these changes

@PierreLaurentinCS PierreLaurentinCS PierreLaurentinCS approved these changes

Assignees
No one assigned
Labels
Beginner's work Documentation Reviewed and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blaisb @lpsaavedra @PierreLaurentinCS