Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pressure constraint gmg #1089

Merged
merged 8 commits into from
Apr 7, 2024
Merged

Pressure constraint gmg #1089

merged 8 commits into from
Apr 7, 2024

Conversation

blaisb
Copy link
Contributor

@blaisb blaisb commented Apr 6, 2024

Description of the problem

  • When the mesh is not homogenous and the domain is closed (e.g. only dirichlet or periodic BCs), the coarse grid solver of the matrix-free GCMG or LSMG does not work. This is because the problem is ill-posed due to the pressure constant.

Description of the solution

  • On the coarse grid level, fix a pressure DOF to be zero by adding a single constraint. This ensures that the solution works.

How Has This Been Tested?

  • I changed the example to use this feature, but I also need to add an application test. Will do so in this PR.

Documentation

  • New parameter is updated and documented.

Comments

  • I am glad this is fixed.

@blaisb blaisb added the WIP When a PR is open but not ready for review label Apr 6, 2024
@blaisb blaisb requested a review from lpsaavedra April 6, 2024 16:47
@blaisb blaisb removed the WIP When a PR is open but not ready for review label Apr 6, 2024
@blaisb
Copy link
Contributor Author

blaisb commented Apr 6, 2024

@lpsaavedra we should merge this after your PR is merged. We just need to regenerate the output. I made it from my mac and it seems to lead to problems

@blaisb blaisb merged commit f824f59 into master Apr 7, 2024
8 checks passed
@blaisb blaisb deleted the pressure_constraint_gmg branch April 7, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants