Inconsistent arg check in writeafid (CID 10439)

chaos · Jun 1, 2011 · 35116d1 · 35116d1
1 parent 6319499
commit 35116d1
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/libdiod/diod_auth.c b/libdiod/diod_auth.c
@@ -226,7 +226,7 @@ writeafid(Npfid *afid, u64 offset, u32 count, u8 *data)
     da_t da;
     int ret = -1;
 
-    if (!afid || !afid->aux || (!data && count > 0)) {
+    if (!afid || !afid->aux || !data || count == 0) {
         np_uerror (EIO);
         err ("writeafid: invalid arguments");
         goto done;