Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-X (freespace) change. Requires existing base directory. #2

Closed
wants to merge 2 commits into from

Conversation

pete4abw
Copy link
Contributor

Further updates to scrub_free and -X handling. Now requires a base directory to exist and will create a random directory under using mkdtemp(). Also made slight change to man page to clarify -X option handling.

@garlick
Copy link
Member

garlick commented Feb 11, 2015

Thanks. A few changes please:

  • squash these commits since second one modifies changes in the first one
  • refer to directory argument as "directory" or "dir" not "basedir" (be consistent)
  • don't change the error -X only takes one directory name. We're not listing all the options that work here.
  • instead of char freespacedir[13]; and a later strcpy. Instead use static initialization without a size.
  • drop comment construct relative path to temp directory in snprint
  • fix directory spellling and s on exists in -X base diirectory %s does not exists

@pete4abw
Copy link
Contributor Author

Thanks for the feedback. I'll clean up tomorrow. Will resync and make consistent.

At least it works! 😀

Peter Hyman
+1(609)598-0262
Sent from mobile. Sorry for any typos.

On February 11, 2015 6:36:24 PM EST, Jim Garlick notifications@github.com wrote:

Thanks. A few changes please:

  • squash these commits since second one modifies changes in the first
    one
  • refer to directory argument as "directory" or "dir" not "basedir" (be
    consistent)
  • don't change the error -X only takes one directory name. We're not
    listing all the options that work here.
  • instead of char freespacedir[13]; and a later strcpy. Instead use
    static initialization without a size.
  • drop comment construct relative path to temp directory in snprint
  • fix directory spellling and s on exists in -X base diirectory %s does not exists

Reply to this email directly or view it on GitHub:
#2 (comment)

@pete4abw pete4abw closed this Feb 12, 2015
sergio-correia added a commit to sergio-correia/scrub that referenced this pull request Aug 19, 2024
If OpenSSL is not explicitly required (ie.g with --with-openssl),
the default keeps being:

1. try to use a HW random generator
2. attempt to use libgcrypt
3. fall back to custom AES implementation, if libgcrypt is
   not available

If OpenSSL is explictly required, step chaos#2 replaces libgcrypt
with openssl.

Signed-off-by: Sergio Correia <scorreia@redhat.com>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants