[servers/fat] Fix fat_file_open case bug #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I discovered another incarnation of #107. The previous fix (in #130) fixed `fat_file_get_info`, _but_ the code was still broken for `fat_file_open`. There was also a weird bug making "no matching file" use the last file that happened to exist in the directory suggested (!). In addition to all of this, `fat_file_open` stupidly duplicated code already present elsewhere. All of this is fixed in this commit. This was the root cause for #132. In other words: Fixes #132.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered another incarnation of #107. The previous fix (in #130)
fixed
fat_file_get_info, but the code was still broken forfat_file_open. There was also a weird bug making "no matching file"use the last file that happened to exist in the directory suggested (!).
In addition to all of this,
fat_file_openstupidly duplicated codealready present elsewhere. All of this is fixed in this commit.
This was the root cause for #132. In other words: Fixes #132.