Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The problem of wrong return value of destroy under non root Linux #100

Merged
merged 1 commit into from
Nov 15, 2021
Merged

Conversation

jfl929930
Copy link
Contributor

Signed-off-by: jfl929930 jfl01231489@alibaba-inc.com

Describe what this PR does / why we need it

When the non root account of Linux performs fault injection, failure will be displayed when the non root account is destroyed. In fact, it is a failure. This is a problem.

Does this pull request fix one issue?

Fixes #597

Describe how you did it

Judge whether the TC command is executed successfully. If it is successful, it will be destroyed. If it is unsuccessful, an error will be returned and the fault status will not be modified

Describe how to verify it

image

Signed-off-by: jfl929930 <jfl01231489@alibaba-inc.com>
@xcaspar xcaspar self-requested a review November 15, 2021 02:16
@xcaspar xcaspar added the type/bug Something isn't working label Nov 15, 2021
@xcaspar xcaspar added this to the v1.4.0 milestone Nov 15, 2021
@xcaspar xcaspar merged commit f123930 into chaosblade-io:1.4.0-dev Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Something isn't working
Projects
None yet
2 participants