Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:the file append experiment is unreasonable #148

Merged
merged 2 commits into from
Jul 15, 2023

Conversation

Yuaninga
Copy link
Contributor

Describe what this PR does / why we need it

This PR will fix the bug: the file append experiment is unreasonable.

Does this pull request fix one issue?

bug report: the file append experiment is unreasonable #824

This PR contains another pr that has not been merged:
fix: failed to create the systemd experiment #147

Describe how you did it

Without interval parameter, it will not be executed regularly.

Describe how to verify it

1.Build a new chaos_os in the chaosblade-exec-os

cd chaosblade-exec-os
make build_linux (on the Mac operating system)
cd target/chaosblade-1.7.0/bin

2.Move the new chaos_os to the chaosblade-1.7.0 from the chaosblade-exec-os

scp chaos_os root@x.x.x.x:/root/chaosblade-1.7.0

3.Replace the old chaos_os

ssh root@x.x.x.x
cd chaosblade-1.7.0/bin
mv chaos_os chaos_os_old
cd ..
mv chaos_os bin/chaos_os

4.create a file append experiment
touch /root/test.log
./blade create file append --filepath=/root/test.log --content="HELL WORLD"
tail -10f /root/test.log

Special notes for reviews

This PR contains another pr that has not been merged:
fix: failed to create the systemd experiment #147

Signed-off-by: Yuaninga <1846225041@qq.com>
Signed-off-by: Yuaninga <1846225041@qq.com>
@tiny-x tiny-x added the type/bug Something isn't working label May 11, 2023
@tiny-x tiny-x added this to the v1.7.2 milestone May 11, 2023
@tiny-x tiny-x added the type/enhancement New feature or request label May 11, 2023
@MandssS MandssS modified the milestones: v1.7.2, v1.7.3 Jun 15, 2023
Copy link
Member

@binbin0325 binbin0325 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MandssS MandssS merged commit 22d784b into chaosblade-io:master Jul 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Something isn't working type/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants