Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update server-deployment.rst #1710

Merged
merged 6 commits into from
Apr 14, 2022
Merged

Update server-deployment.rst #1710

merged 6 commits into from
Apr 14, 2022

Conversation

lylynaheng
Copy link
Contributor

Pull Request server-deployment.rst

@sgoggins
Copy link
Member

@lylynaheng
Copy link
Contributor Author

@sgoggins I am not sure how to sign commit from GitHub Desktop. I followed the steps in the link, but it doesn't say anything about sign commit from GitHub Desktop.

Copy link
Member

@sgoggins sgoggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lylynaheng
Copy link
Contributor Author

I double check the signed document on GitHub and I believe that my commits are signed and verified.

Screen Shot 2022-04-12 at 2 06 22 PM

lylynaheng and others added 4 commits April 13, 2022 14:08
Signed-off-by: Lylyna Heng <lylynaheng@gmail.com>
Signed-off-by: Lylyna Heng <lylynaheng@gmail.com>
…/1710

It is necessary to sign off the commit.

Signed-off-by: Lylyna Heng <lylynaheng@gmail.com>
sgoggins
sgoggins previously approved these changes Apr 14, 2022
@sgoggins sgoggins merged commit 73fa25a into chaoss:main Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants