use a fully qualified name for the container #1904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mscherer : Do you have an idea why the nginx / npm stuff is failing on GitHub. I assume its not failing locally for you. Can you think of any configs we may need to change? |
|
I think the issue was a js deps upgrade. I know my patch is not changing that, I will take a look and provides a patch. |
|
So I can't figure (yet) what break the build. I tried using git bisest, but even old revision seems to fail, so either my hypothesis is wrong, or my git biest command was wrong. |
|
So it build outside of the container on my Fedora 35 system. |
While this work to build with docker, podman/buildah stop the build to ask which image to use, preventing a build in a script. Signed-off-by: Michael Scherer <misc@redhat.com>
mscherer
force-pushed
the
use_qualified_name
branch
2 times, most recently
from
e861531
to
6b6999e
Compare
Otherwise, builds are not reproductible on the CI, which tend to greatly confuse coders (for N=1) who try to debug why it doesn't build. Signed-off-by: Michael Scherer <misc@redhat.com>
mscherer
force-pushed
the
use_qualified_name
branch
from
6b6999e
to
fbbe2ec
Compare
sgoggins
approved these changes
Jul 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While this work to build with docker, podman/buildah stop the
build to ask which image to use, preventing a build in a script.
Notes for Reviewers
Signed commits