Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use a fully qualified name for the container #1904

Merged
merged 2 commits into from
Jul 20, 2022
Merged

use a fully qualified name for the container #1904

merged 2 commits into from
Jul 20, 2022

Commits on Jul 6, 2022

  1. use a fully qualified name for the container 

    While this work to build with docker, podman/buildah stop the
build to ask which image to use, preventing a build in a script.

Signed-off-by: Michael Scherer <misc@redhat.com>
    @mscherer
    mscherer committed Jul 6, 2022
    Configuration menu
    Copy the full SHA
    9db3fe0 View commit details
    Browse the repository at this point in the history

  2. Copy package-lock.json in the container build 

    Otherwise, builds are not reproductible on the CI, which tend
to greatly confuse coders (for N=1) who try to debug why it doesn't
build.

Signed-off-by: Michael Scherer <misc@redhat.com>
    @mscherer
    mscherer committed Jul 6, 2022
    Configuration menu
    Copy the full SHA
    fbbe2ec View commit details
    Browse the repository at this point in the history