Remove the use of shell for mkdir -p #2314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release 0.50.1
Release 0.50.2
See https://stackoverflow.com/questions/600268/mkdir-p-functionality-in-python Signed-off-by: Michael Scherer <misc@redhat.com>
IsaacMilarky
requested changes
Apr 12, 2023
|
|
||
| raise Exception("Could not create git repo's prerequisite directories. " | ||
| " Do you have write access?") | ||
| pathlib.Path(repo_path).mkdir(parents=True, exist_ok=True) |
There was a problem hiding this comment.
This is a good change however it should still catch any exceptions Path.mkdir raises and respond like how it did before when we didn't get a return code. It should update its internal logs when it is unable to create the directory.
There was a problem hiding this comment.
Just put the mkdir line in a try/except block and put the body of the if statement on line 123 in the exception handle. Otherwise looks good.
handle when mkdir call doesn't work for whatever reason.
IsaacMilarky
approved these changes
Apr 12, 2023
sgoggins
reviewed
Apr 14, 2023
There was a problem hiding this comment.
@IsaacMilarky / @ABrain7710 : Could you go ahead and review this?
ABrain7710
approved these changes
Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://stackoverflow.com/questions/600268/mkdir-p-functionality-in-python
Description
This PR fixes a problem I bumped into while deploying (eg, the container do not work without /bin in PATH). I have a workaround for my setup, but it is better to fix the root cause.
Notes for Reviewers
Signed commits