Remove the use of shell for mkdir -p

README.md

@@ -1,4 +1,4 @@
-# Augur NEW Release v0.50.1
+# Augur NEW Release v0.50.2
 
 [![first-timers-only](https://img.shields.io/badge/first--timers--only-friendly-blue.svg?style=flat-square)](https://www.firsttimersonly.com/) We follow the [First Timers Only](https://www.firsttimersonly.com/) philosophy of tagging issues for first timers only, and walking one newcomer through the resolution process weekly. [You can find these issues tagged with "first timers only" on our issues list.](https://github.com/chaoss/augur/labels/first-timers-only).
 
@@ -8,7 +8,7 @@
 ### [If you want to jump right in, updated docker build/compose and bare metal installation instructions are available here](docs/new-install.md)
 
 
-Augur is now releasing a dramatically improved new version to the main branch. It is also available here: https://github.com/chaoss/augur/releases/tag/v0.50.1
+Augur is now releasing a dramatically improved new version to the main branch. It is also available here: https://github.com/chaoss/augur/releases/tag/v0.50.2
 - The `main` branch is a stable version of our new architecture, which features:
   - Dramatic improvement in the speed of large scale data collection (100,000+ repos). All data is obtained for 100k+ repos within 2 weeks.
   - A new job management architecture that uses Celery and Redis to manage queues, and enables users to run a Flower job monitoring dashboard

augur/tasks/git/util/facade_worker/facade_worker/facade05repofetch.py

@@ -36,6 +36,7 @@
 import getopt
 import xlsxwriter
 import configparser
+import pathlib
 import sqlalchemy as s
 from .facade02utilitymethods import update_repo_log, trim_commit, store_working_author, trim_author, get_absolute_repo_path
 from augur.application.db.models.augur_data import *
@@ -114,21 +115,16 @@ def git_repo_initialize(session, repo_git):
             return 
 
         # Create the prerequisite directories
-        return_code = subprocess.Popen([f"mkdir -p {repo_path}"],shell=True).wait()
-#        session.log_activity('Info','Return code value when making directors from facade05, line 120: {:d}'.format(return_code))
-
-
-
-        # Make sure it's ok to proceed
-        if return_code != 0:
-            print("COULD NOT CREATE REPO DIRECTORY")
+	try:
+        	pathlib.Path(repo_path).mkdir(parents=True, exist_ok=True)
+	except Exception as e:
+	    print("COULD NOT CREATE REPO DIRECTORY")
 
             update_repo_log(session, row.repo_id,'Failed (mkdir)')
             session.update_status(f"Failed (mkdir {repo_path})")
             session.log_activity('Error',f"Could not create repo directory: {repo_path}" )
-
-            raise Exception("Could not create git repo's prerequisite directories. "
-                " Do you have write access?")
+
+	    raise e
 
         update_repo_log(session, row.repo_id,'New (cloning)')
 

docker/backend/Dockerfile

@@ -2,7 +2,7 @@
 FROM python:3.8.11-slim-buster
 
 LABEL maintainer="outdoors@acm.org"
-LABEL version="0.50.1"
+LABEL version="0.50.2"
 
 ENV DEBIAN_FRONTEND=noninteractive
 

docker/database/Dockerfile

@@ -2,7 +2,7 @@
 FROM postgres:12
 
 LABEL maintainer="outdoors@acm.org"
-LABEL version="0.50.1"
+LABEL version="0.50.2"
 
 ENV POSTGRES_DB "test"
 ENV POSTGRES_USER "augur"

metadata.py

@@ -5,8 +5,8 @@
 
 __short_description__ = "Python 3 package for free/libre and open-source software community metrics, models & data collection"
 
-__version__ = "0.50.1"
-__release__ = "v0.50.1 (Springtime for Metrics!)"
+__version__ = "0.50.2"
+__release__ = "v0.50.2 (Springtime for Metrics!)"
 
 __license__ = "MIT"
 __copyright__ = "University of Missouri, University of Nebraska-Omaha, CHAOSS, Brian Warner & Augurlabs 2023"