Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update metrics.py, esquery.py and test_esquery.py to use only elasticsearch_dsl module #60

Closed
aswanipranjal opened this issue May 27, 2018 · 0 comments
Closed

Update metrics.py, esquery.py and test_esquery.py to use only elasticsearch_dsl module #60

aswanipranjal opened this issue May 27, 2018 · 0 comments

Comments

@aswanipranjal
Copy link
Contributor

aswanipranjal commented May 27, 2018 •
edited
Loading

After #57, this issue adds the use of elasticsearch_dsl to other files such as metrics.py.

esquery.py in the function get_aggs, returns a json dict which is then used in metrics.py to get the results via requests.get method.
This issue is about removing completely the direct querying to elasticsearch and using elasticsearch_dsl.py instead.

EDIT: The second PR is ready, Please review #58 so that the second PR can be added on top of it.
@aswanipranjal aswanipranjal changed the title Update metrics.py and test_esquery.py to use only elasticsearch_dsl module Update metrics.py, esquery.py and test_esquery.py to use only elasticsearch_dsl module May 27, 2018
aswanipranjal added a commit to aswanipranjal/grimoirelab-manuscripts that referenced this issue May 27, 2018
@aswanipranjal
Closes chaoss#60
a5db965 
Update metrics.py, esquery.py and test_esquery.py to completely
use elasticsearch_dsl module and remove any other methods to
access results from elasticsearch.
aswanipranjal added a commit to aswanipranjal/grimoirelab-manuscripts that referenced this issue Jun 3, 2018
@aswanipranjal
Closes chaoss#60
268547e 
Elaborate on comments of functions in esquery.py file.
Remove querying elasticsearch directly from metrics.py file and
use elasticsearch_dsl instead.
Modify test to compare dicts in get_agg in test_esquery.py.
aswanipranjal added a commit to aswanipranjal/grimoirelab-manuscripts that referenced this issue Jun 3, 2018
@aswanipranjal
Closes chaoss#60
c656691 
Updated comments in esquery.py.
Metrics.py uses elasticsearch_dsl.py instead of directly
requesting easticsearch for data.
Updated test for get_agg.
aswanipranjal added a commit to aswanipranjal/grimoirelab-manuscripts that referenced this issue Jun 4, 2018
@aswanipranjal
Closes chaoss#60
c79656a 
Updated comments in esquery.py.
Metrics.py uses elasticsearch_dsl.py instead of directly
requesting easticsearch for data.
Updated test for get_agg.
aswanipranjal added a commit to aswanipranjal/grimoirelab-manuscripts that referenced this issue Jun 7, 2018
@aswanipranjal
Closes chaoss#60
f67bf07 
Updated comments in esquery.py.
Metrics.py uses elasticsearch_dsl.py instead of directly
requesting easticsearch for data.
Updated test for get_agg.
@jgbarah jgbarah closed this as completed in 10e5707 Jun 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aswanipranjal