Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creating chainable functions and New Classes to calculate the Metrics #62

Closed
aswanipranjal opened this issue May 31, 2018 · 3 comments
Closed

Creating chainable functions and New Classes to calculate the Metrics #62

aswanipranjal opened this issue May 31, 2018 · 3 comments

Comments

@aswanipranjal
Copy link
Contributor

aswanipranjal commented May 31, 2018 •
edited
Loading

This issue proposes creating functions to segregate the metrics according to different fields, such as: by_author, by_organizations and by_period (weeks, months, years) which can be applied directly to metrics objects and the corresponding aggregations can be obtained.

These functions will make it easier for the user to do analysis on the basis of different users or orgs and to see the metrics evolve over periodic intervals.

They've been currently implemented in this file as a part of the Metric class.

We will also be creating new classes to calculate the metrics.
@aswanipranjal aswanipranjal changed the title Creating chainable functions Creating chainable functions and New Classes to calculate the Metrics May 31, 2018
@jgbarah
Copy link
Contributor

jgbarah commented May 31, 2018

I like the approach. Maybe later we need specialized versions of these functions, such as for example when we have different records to consider in some specific case, or parameters for the functions. But for now, I guess we can try reimplementing with this, and we will already have a big win ;-)

We still need to comment how to integrate this in a giant pr with everything, or in separate ones, but I like it as a proof of concept.

Could you please write also some examples of use of these chainable methods, so that they are easier to understand to others?

aswanipranjal added a commit to aswanipranjal/grimoirelab-manuscripts that referenced this issue Jun 12, 2018
@aswanipranjal
Adding manuscripts2 folder containing:
d79b64d 
- new_functions.py file containing the basic classes and functions
- derived_classes.py file containing the derived classes
- Readme.md describing how to use the above 2 files

Addresses issues chaoss#59 and chaoss#62
aswanipranjal added a commit to aswanipranjal/grimoirelab-manuscripts that referenced this issue Jun 12, 2018
@aswanipranjal
Adding manuscripts2 folder containing:
8bc1914 
- new_functions.py file which has the basic classes and functions
- derived_classes.py file which has the derived classes
- Readme.md describing how to use the above 2 files

Addresses issues chaoss#59 and chaoss#62
@aswanipranjal aswanipranjal mentioned this issue Jun 12, 2018
Merged
aswanipranjal added a commit to aswanipranjal/grimoirelab-manuscripts that referenced this issue Jun 24, 2018
@aswanipranjal
Adding manuscripts2 folder containing:
4f3093a 
- new_functions.py file which has the basic classes and functions
- derived_classes.py file which has the derived classes
- Readme.md describing how to use the above 2 files
- sample_metrics.ipynb describing how the classes can be used
- tests for the basic functions inside the Query class

Addresses issues chaoss#59 and chaoss#62
aswanipranjal added a commit to aswanipranjal/grimoirelab-manuscripts that referenced this issue Jun 26, 2018
@aswanipranjal
Adding manuscripts2 folder containing:
73b7813 
- new_functions.py file which has the basic classes and functions
- derived_classes.py file which has the derived classes
- Readme.md describing how to use the above 2 files
- sample_metrics.ipynb describing how the classes can be used
- tests for the basic functions inside the Query class

Addresses issues chaoss#59 and chaoss#62
aswanipranjal added a commit to aswanipranjal/grimoirelab-manuscripts that referenced this issue Jun 26, 2018
@aswanipranjal
Adding manuscripts2 folder containing:
8821bca 
- new_functions.py file which has the basic classes and functions
- derived_classes.py file which has the derived classes
- Readme.md describing how to use the above 2 files
- sample_metrics.ipynb describing how the classes can be used
- tests for the basic functions inside the Query class

Addresses issues chaoss#59 and chaoss#62
aswanipranjal added a commit to aswanipranjal/grimoirelab-manuscripts that referenced this issue Jun 27, 2018
@aswanipranjal
Adding manuscripts2 folder containing:
56710ed 
- new_functions.py file which has the basic classes and functions
- derived_classes.py file which has the derived classes
- Readme.md describing how to use the above 2 files
- sample_metrics.ipynb describing how the classes can be used
- tests for the basic functions inside the Query class

Addresses issues chaoss#59 and chaoss#62
aswanipranjal added a commit to aswanipranjal/grimoirelab-manuscripts that referenced this issue Jun 29, 2018
@aswanipranjal
Adding manuscripts2 folder, containing:
b264441 
- new_functions.py file which has the classes and functions
to Query and implement the metrics
- derived_classes.py file which has the derived classes:
 Issues and PullRequests
- Readme.md describing how to use the above 2 files
- sample_metrics.ipynb listing the current CHAOSS metrics as well
as GMD metrics
- tests for the basic functions inside the Query class

Addresses issues chaoss#59 and chaoss#62
aswanipranjal added a commit to aswanipranjal/grimoirelab-manuscripts that referenced this issue Jul 4, 2018
@aswanipranjal
Add manuscripts2 containing new functions to calculate the metrics
e864750 
- new_functions.py: contains Query & Index classes and functions
to parse the fetched data
- derived_classes.py: contains PullRequests and Issues classes
- Readme.md describing how to use the above 2 files
- tests for the basic functions inside the Query class

Also add:
- Examples/Sample_metrics.ipynb: contains the CHAOSS and GMD
metrics that are being calculated using the new functions

Addresses issues chaoss#59 and chaoss#62
jgbarah pushed a commit that referenced this issue Jul 6, 2018
@aswanipranjal @jgbarah
Add manuscripts2 containing new functions to calculate the metrics
6b25218 
- new_functions.py: contains Query & Index classes and functions
to parse the fetched data
- derived_classes.py: contains PullRequests and Issues classes
- Readme.md describing how to use the above 2 files
- tests for the basic functions inside the Query class

Also add:
- Examples/Sample_metrics.ipynb: contains the CHAOSS and GMD
metrics that are being calculated using the new functions

Addresses issues #59 and #62
@jgbarah
Copy link
Contributor

jgbarah commented Jul 18, 2018

Can we close this, @aswanipranjal?

@aswanipranjal
Copy link
Contributor Author

Yeah, it's about time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jgbarah @aswanipranjal