You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Even when the structure in manuscripts2 starts to take shape, we need to discuss better names for the structures there. For example, "new_functions" is not a good name ;-)
Could we discuss here how to name files, classes and methods?
The text was updated successfully, but these errors were encountered:
Since I see no movement here, let me start with a proposal.
Files:
new_functions.py to elasticsearch.py (since it deals with queries to ES).
derived_classes.py, for now, could be in elasticsearch.py to, since it is very little code, and not really different.
test_new_functions.py could move to tests/test_elasticsearch.py (that is, in the tests directory of the repo), so that we have tests integrated, and working.
Readme.md could be README.md
In addition, we would need to modify setup.py so that manuscripts2 is included in the package, and can thus be installed and tested automatically.
For now, we can leave the names of the classes and methods as they are. We could revisit that later...
I am sorry, I couldn't think of any appropriate names. Thanks for this proposal! These are totally fine with me. I'll make the changes and create a PR.
Even when the structure in manuscripts2 starts to take shape, we need to discuss better names for the structures there. For example, "new_functions" is not a good name ;-)
Could we discuss here how to name files, classes and methods?
The text was updated successfully, but these errors were encountered: