Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename new_functions.py to elasticsearch.py #78

Merged
merged 1 commit into from
Jul 19, 2018
Merged

Rename new_functions.py to elasticsearch.py #78

merged 1 commit into from
Jul 19, 2018

Conversation

aswanipranjal
Copy link
Contributor

@aswanipranjal aswanipranjal commented Jul 19, 2018 •
edited
Loading

  • Rename new_functions.py to elasticsearch.py
  • Move PullRequests and Issues classes to elasticsearch.py
  • Delete mansucripts2/derived_classes.py
  • Update other files as a result of the rename

closes #72

@aswanipranjal
Rename manuscripts2/new_functions.py -> manuscripts2/elasticsearch.py
7cefc0d 
Move PullRequests and Issues classes to elasticsearch.py
Delete mansucripts2/derived_classes.py
jgbarah
jgbarah approved these changes Jul 19, 2018
View reviewed changes
Copy link
Contributor

@jgbarah jgbarah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm accepting this, thanks. But please, change the name of the readme to README.md too, when you can.

@aswanipranjal
Copy link
Contributor Author

I am sorry! I'll do it in the next PR I make.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 188

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 55.309%
Totals Coverage Status
Change from base Build 187: -0.03%
Covered Lines: 849
Relevant Lines: 1535
💛 - Coveralls

@jgbarah jgbarah merged commit a494047 into chaoss:master Jul 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgbarah jgbarah jgbarah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New names for files, classes in manuscripts2
3 participants
@aswanipranjal @coveralls @jgbarah