Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calculate the default start date using all the data sources provided #69

Merged
merged 1 commit into from Jul 3, 2018
Merged

Calculate the default start date using all the data sources provided #69

merged 1 commit into from Jul 3, 2018

Conversation

aswanipranjal
Copy link
Contributor

@aswanipranjal aswanipranjal commented Jun 22, 2018 •
edited

Initially the start date argument for manuscripts was was hardcoded to be 2015-01-01 as it's default value. Link.

This PR adds the functionality to calculate the start date by querying all the specified elasticsearch indices, getting the minimum grimoire_creation_date field from them and then taking the minimum date from all those minimum dates queried and sets that as the start date if it is not provided.

This way we get the analysis from the first time the project was initialised or the first time a message was sent to the mailinglists and so on depending on the data sources provided.

closes #48

@aswanipranjal
Closes chaoss#48
002cbb0 
If start date is not provided then all the indices present will be
queried and the min "grimoire_creationd_date" amongst those indices
will be set as the start date for that report.
@jgbarah jgbarah requested a review from acs June 27, 2018 10:59
jgbarah
jgbarah reviewed Jun 27, 2018
View reviewed changes
Copy link
Contributor

@jgbarah jgbarah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. But please, edit the title of the pr to a meaningful title, and have some description in it (so that we can more easily understand it at first glance in the future).

@aswanipranjal aswanipranjal changed the title Closes #48 Calculate the default start date using all the data sources provided Jun 27, 2018
@jgbarah jgbarah merged commit ffc3634 into chaoss:master Jul 3, 2018
@aswanipranjal aswanipranjal deleted the change-start-date branch July 8, 2018 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgbarah jgbarah jgbarah left review comments

@acs acs Awaiting requested review from acs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change start_date from '2015-01-01' to the date of the first commit
2 participants
@aswanipranjal @jgbarah