[report] Add functionality to calculate PROJECT ACTIVITY section of the report #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aswanipranjal
force-pushed
the
generate-new-reports
branch
from
eb7c8c5
to
23b40e5
Compare
|
@valeriocos @jgbarah I think this PR is big enough on it's own and I should create a separate PR adding the tests for the functions used to create the reports. Will that be okay with you? |
aswanipranjal
force-pushed
the
generate-new-reports
branch
from
23b40e5
to
dae3f71
Compare
|
@aswanipranjal, I agree with you. You could also split the 3 bullet points listed in the description of this PR in 3 different PRs. |
- This code adds the `get_sec_project_activity` function which calculates the project activity section of the report. - This also merges the `create_csv_from_df` and `create_fig_from_df` functions into `create_csv_fig_from_df` so that the code is a bit less cluttered and because these functions were being called one after the other.
aswanipranjal
force-pushed
the
generate-new-reports
branch
from
dae3f71
to
70bec03
Compare
|
@valeriocos I am dividing this PR into 4 parts, one for reports section and the other 3 for the 3 data sources. |
aswanipranjal
changed the title
|
@valeriocos I am finished with the PRs, please review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes to add the
project activitysection of the report forgit,github_issuesand
github_prsdata sources.get_sec_project_activity()function which calculates the PROJECT ACTIVITY section of the report and stores the data into aproject_activityfolder.create_csv_from_dfandcreate_fig_from_dfintocreate_csv_fig_from_dffunction so that the code is a bit less cluttered and is easier to usage.