Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Update the mariadb docker-compose configuration #501

Merged
merged 1 commit into from
Apr 12, 2021

Conversation

SourabhSaraswat-191939
Copy link
Contributor

Signed-off-by: Sourabh Saraswat saraswatsourabh5@gmail.com

expose =>as it activates container to listen for a specific port only from the world inside of docker AND not accessible from world outside of the docker . So that's why this create an issue with connection to database when we run micro-mordred .
as per reference https://docs.docker.com/engine/reference/builder/#expose

So to overcome this we can use :
ports => as it activates the container to listen for specified port(s) from the world outside of the docker AND also accessible world inside docker.

and there is one more issue while setting up grimoire lab from docker-compose (with SearchGuard) that it have no database with name of "test_sh" which creates an error "no database of name 'test_sh' " while running micro-mordred .
So for this , i added a database of this name in mysql by default .

@coveralls
Copy link

coveralls commented Apr 1, 2021

Pull Request Test Coverage Report for Build 711084673

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 63.351%

Totals Coverage Status
Change from base Build 653735335: -0.03%
Covered Lines: 1070
Relevant Lines: 1689

💛 - Coveralls

@vchrombie
Copy link
Member

Related to #500 (comment)

Copy link
Member

@vchrombie vchrombie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you @SourabhSaraswat-191939.

I understand that the MariaDB can have the same configuration for both docker-compose (with and without search guard). So, it would be great if you can update the search guard mariadb similar to the without search guard.

@vchrombie
Copy link
Member

You need not create a new PR, you can add the changes to the same commit.
Please use --amend during git commit and --force during git push.

Let us know if you need help.

@SourabhSaraswat-191939
Copy link
Contributor Author

it would be great if you can update the search guard mariadb similar to the without search guard.

Sure, i will do that .

Please use --amend during git commit and --force during git push.

Okay 👍🏻 .

@SourabhSaraswat-191939 SourabhSaraswat-191939 changed the title Add ports and database name for mariadb Add ports, database name, restart and command for mariadb Apr 1, 2021
@SourabhSaraswat-191939
Copy link
Contributor Author

If there is any change still requires then let me know that .

Copy link
Member

@vchrombie vchrombie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution.

@vchrombie
Copy link
Member

The changes look good to me, but it would be great if you can update the commit message with a small description and a proper title as per the commit message guidelines.

[docs] Update the mariadb docker-compose configuration

This commit updates the mariadb docker-compose configuration in the 
docker-compose with search guard section of the Getting-Started.md doc.

Resolves: https://github.com/chaoss/grimoirelab-sirmordred/issues/500

You can amend the commit, change the commit message and force push it.

Let me know if you need any help.

@SourabhSaraswat-191939
Copy link
Contributor Author

The changes look good to me, but it would be great if you can update the commit message with a small description and a proper title as per the commit message guidelines.

Done 👍🏻

@SourabhSaraswat-191939 SourabhSaraswat-191939 changed the title Add ports, database name, restart and command for mariadb [docs] Update the mariadb docker-compose with SearchGuard configuration Apr 1, 2021
This commit updates the mariadb docker-compose configuration in the
docker-compose with search guard section of the Getting-Started.md doc.

Resolves: chaoss#500

Signed-off-by: Sourabh Saraswat <saraswatsourabh5@gmail.com>
@SourabhSaraswat-191939 SourabhSaraswat-191939 changed the title [docs] Update the mariadb docker-compose with SearchGuard configuration [docs] Update the mariadb docker-compose configuration Apr 2, 2021
Copy link
Member

@sduenas sduenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sduenas sduenas merged commit 9a11092 into chaoss:master Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants