-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Update the mariadb docker-compose configuration #501
Conversation
Pull Request Test Coverage Report for Build 711084673
💛 - Coveralls |
e0f6249
to
eec9563
Compare
Related to #500 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, thank you @SourabhSaraswat-191939.
I understand that the MariaDB can have the same configuration for both docker-compose (with and without search guard). So, it would be great if you can update the search guard mariadb similar to the without search guard.
You need not create a new PR, you can add the changes to the same commit. Let us know if you need help. |
Sure, i will do that .
Okay 👍🏻 . |
cf95630
to
f25843d
Compare
If there is any change still requires then let me know that . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for your contribution.
The changes look good to me, but it would be great if you can update the commit message with a small description and a proper title as per the commit message guidelines.
You can amend the commit, change the commit message and force push it. Let me know if you need any help. |
f25843d
to
16a2f99
Compare
Done 👍🏻 |
This commit updates the mariadb docker-compose configuration in the docker-compose with search guard section of the Getting-Started.md doc. Resolves: chaoss#500 Signed-off-by: Sourabh Saraswat <saraswatsourabh5@gmail.com>
16a2f99
to
443ca45
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Sourabh Saraswat saraswatsourabh5@gmail.com
expose =>as it activates container to listen for a specific port only from the world inside of docker AND not accessible from world outside of the docker . So that's why this create an issue with connection to database when we run micro-mordred .
as per reference https://docs.docker.com/engine/reference/builder/#expose
So to overcome this we can use :
ports => as it activates the container to listen for specified port(s) from the world outside of the docker AND also accessible world inside docker.
and there is one more issue while setting up grimoire lab from docker-compose (with SearchGuard) that it have no database with name of "test_sh" which creates an error "no database of name 'test_sh' " while running micro-mordred .
So for this , i added a database of this name in mysql by default .