[sortinghat] Add logging support #153
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sduenas
requested changes
Jun 26, 2018
sortinghat/command.py
Outdated
| sys.stdout.write(s) | ||
|
|
||
| def error(self, msg): | ||
| s = "Error: %s\n" % msg | ||
| sys.stderr.write(s) | ||
| logger.error(s) |
There was a problem hiding this comment.
I wouldn't change this. We have to make a difference between those messages related to the internal work of the tool (log messages) and those messages generated as an output for the user (which is this case).
There was a problem hiding this comment.
ok @sduenas, I'm going to revert this change and update the PR
|
I have updated the pr according to your comments @sduenas , please have a look |
sduenas
requested changes
Jun 27, 2018
sortinghat/command.py
Outdated
| @@ -57,7 +60,8 @@ def display(self, template, **kwargs): | |||
|
|
|||
| t = env.get_template(template) | |||
| s = t.render(**kwargs) | |||
|
|
|||
| logger.info(s) | |||
There was a problem hiding this comment.
This should be also removed as you did with the errors.
|
I have updated the PR, including changes due to the inclusion of #155 to the codebase. |
This code aligns test code with the support for logging. The modification was required since after including this support, tests were failing due to the way of checking the outcome of commands (stdin, stderr) which was clashing with the logger output.
This code includes the cryptography package in the travis.yml, in order to make the tests pass.
sduenas
approved these changes
Jun 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR targets issue #149 . Thus it includes support to for logging.