Use a optimistic approach when inserting data #155
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this optimistic approach, no more queries to check
whether an entity exists on the database are run prior to
its insertion. The new procedure works as follows:
* Try to insert an entity without checking whether it exists in
the database or not.
* If the entity exists, an IntegrityError or a FlushError will
be raised.
* Rollback the transaction
* Catch this error and check if it is an error raised by a
duplicate entry.
* If that was the cause, handle the error and raise an
`AlreadyExistsError`.
Some changes were needed in `AlreadyExistsError` exception to
store the ID and the type of the duplicated entry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to fix the enhancement proposed in #151.
With this optimistic approach, no more queries to check whether an entity exists on the database are run prior to its insertion. The new procedure works as follows:
IntegrityErroror aFlushErrorwill be raised.AlreadyExistsError.Some changes were needed in
AlreadyExistsErrorexception to store the ID and the type of the duplicated entry.