Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GSoC] Add tests for the utils and conditions modules (with pandas) #211

Merged
merged 4 commits into from Aug 12, 2019

Conversation

Polaris000
Copy link
Contributor

This pull request adds tests for the utils and conditions modules belonging to the pandas hierarchy of implementations.

Copy link
Collaborator

@jgbarah jgbarah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, rebase with current HEAD of the repo.

@Polaris000
Copy link
Contributor Author

Please have a look @jgbarah

This patch adds tests for utils.py for the pandas
implementation. 
 
Signed-off-by: Aniruddha Karajgi <akarajgi0@gmail.com>
This patch adds tests for the conditions module of 
the pandas series of implementations.
It also modifies test commit json data to better test
the PostfixExclude class.
 
Signed-off-by: Aniruddha Karajgi <akarajgi0@gmail.com>
This patch adds additional commit testing data and
updates tests for the utils and conditions modules 
for travis support.
 
Signed-off-by: Aniruddha Karajgi <akarajgi0@gmail.com>
This patch fixes a class error in conditions.py and the
tests for the conditions module. 
 
Signed-off-by: Aniruddha Karajgi <akarajgi0@gmail.com>
@Polaris000
Copy link
Contributor Author

Travis passed. Please have a look @jgbarah .

Copy link
Collaborator

@jgbarah jgbarah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging. Thanks!

@jgbarah jgbarah merged commit 5ab6b37 into chaoss:master Aug 12, 2019
@Polaris000 Polaris000 deleted the UtilsAndConditionsTests branch August 12, 2019 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants