[GSoC] Implement new naming convention and fix imports #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgbarah
requested changes
Aug 6, 2019
This patch implements a new naming scheme for modules. It also fixes a few typos and flake8 formatting errors. Signed-off-by: Aniruddha Karajgi <akarajgi0@gmail.com>
This patch adds the __str__ method to all classes. It also changes the import style to absolute for the non-pandas metrics. Signed-off-by: Aniruddha Karajgi <akarajgi0@gmail.com>
Polaris000
force-pushed
the
CleanUp
branch
8 times, most recently
from
b35ca55
to
a046e0a
Compare
|
@jgbarah, I got travis to work, but there is a small hiccup: I keep having to add the project path to PYTHONPATH in the export PYTHONPATH=$PYTHONPATH:$(pwd)The tests and coverage run as expected locally, but for some reason, the I have fixed all imports, added the |
Polaris000
changed the title
This patch fixes the import system in tests. It also updates the structure of the tests directory. Signed-off-by: Aniruddha Karajgi <akarajgi0@gmail.com>
This patch improves tests and the coverage report excluded lines section. Signed-off-by: Aniruddha Karajgi <akarajgi0@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements a new naming scheme
for modules. It also fixes a few typos and flake8
formatting errors.