New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GSoC] Add reference implementation for Issues Active #235
Conversation
This patch adds the python script for the Issues Active metric using pandas. Signed-off-by: Aniruddha Karajgi <akarajgi0@gmail.com>
Notebooks and tests will be added soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, check specific comment.
|
||
return [flat] | ||
|
||
def compute(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this works. We're defining "active issues" as those that had some change in state or comment during the period, and this is not capturing that... Have in mind that "updated_date", if I'm not wrong, is giving only the last update to the issue...
I think you need to explore Perceval, to see how this information can be captured, I think it is not captured by default.
If needed, maybe @valeriocos can help here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jgbarah, I was going to discuss this in today's meeting. As far as I know, Perceval does not handle events too well. You're right about the updated_date
meaning. I have opened an issue in Perceval which mentions this, but not specifically. I'll reword that issue or open a new one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, let's discuss today.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is still not ready?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think issues in Perceval are still not solved. @Polaris000, if I'm right, what do you think about closing this pr? When Perceval is ready, we could produce a new patch: it will very likely be different from this one, anyway...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. Closing it for now..
This pull request adds the reference implementation for the Issues
Active metric using pandas.