[GSoC] Add a few missing tests #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds tests for the non-pandas version of the Reviews Accepted metric implementation. Signed-off-by: Aniruddha Karajgi <akarajgi0@gmail.com>
This patch adds tests for the non-pandas version of the Code Changes Git reference implementation. Signed-off-by: Aniruddha Karajgi <akarajgi0@gmail.com>
This patch adds tests for the Code Changes Lines reference implementation and renames a test for Code Changes implementation. Signed-off-by: Aniruddha Karajgi <akarajgi0@gmail.com>
This patch adds tests for the non-pandas version of Reviews Accepted reference implementation. Signed-off-by: Aniruddha Karajgi <akarajgi0@gmail.com>
This patch adds tests for the non-pandas version of the Reviews reference implementation. Signed-off-by: Aniruddha Karajgi <akarajgi0@gmail.com>
valeriocos
approved these changes
Aug 14, 2019
There was a problem hiding this comment.
LGTM, thanks @Polaris000 .
Please try to increase the test coverage. To check the current coverage, you can use the package coverage and execute:
cd wg-evolution/implementations/tests
coverage/__main__.py run run_tests.py --source=../code_df,..scripts
coverage/__main__.py report -m
The output should be something similar to:
Name Stmts Miss Cover Missing
-----------------------------------------------------------------------------------------------------------------------------------------
/home/slimbook/Escritorio/sources/wg-evolution/implementations/code_df/__init__.py 0 0 100%
/home/slimbook/Escritorio/sources/wg-evolution/implementations/code_df/code_changes_git.py 12 1 92% 52
/home/slimbook/Escritorio/sources/wg-evolution/implementations/code_df/code_changes_lines_git.py 41 7 83% 31, 34, 64, 76-79, 85, 132
/home/slimbook/Escritorio/sources/wg-evolution/implementations/code_df/commit_git.py 37 1 97% 68
/home/slimbook/Escritorio/sources/wg-evolution/implementations/code_df/conditions.py 57 0 100%
/home/slimbook/Escritorio/sources/wg-evolution/implementations/code_df/issue_github.py 14 0 100%
/home/slimbook/Escritorio/sources/wg-evolution/implementations/code_df/metric.py 14 0 100%
/home/slimbook/Escritorio/sources/wg-evolution/implementations/code_df/pullrequest_github.py 14 0 100%
/home/slimbook/Escritorio/sources/wg-evolution/implementations/code_df/reviews_accepted_github.py 13 1 92% 52
/home/slimbook/Escritorio/sources/wg-evolution/implementations/code_df/reviews_declined_github.py 13 1 92% 55
/home/slimbook/Escritorio/sources/wg-evolution/implementations/code_df/reviews_github.py 12 1 92% 50
/home/slimbook/Escritorio/sources/wg-evolution/implementations/code_df/utils.py 16 0 100%
/home/slimbook/Escritorio/sources/wg-evolution/implementations/scripts/__init__.py 0 0 100%
/home/slimbook/Escritorio/sources/wg-evolution/implementations/scripts/code_changes_git.py 8 0 100%
/home/slimbook/Escritorio/sources/wg-evolution/implementations/scripts/code_changes_lines_git.py 39 7 82% 31, 34, 64, 76-79, 85, 106
/home/slimbook/Escritorio/sources/wg-evolution/implementations/scripts/commit_git.py 36 7 81% 36-37, 40, 45-48, 68, 96
/home/slimbook/Escritorio/sources/wg-evolution/implementations/scripts/conditions.py 55 24 56% 109, 141-144, 167-184, 208-211, 234-237
/home/slimbook/Escritorio/sources/wg-evolution/implementations/scripts/metric.py 7 0 100%
/home/slimbook/Escritorio/sources/wg-evolution/implementations/scripts/pullrequest_github.py 14 0 100%
/home/slimbook/Escritorio/sources/wg-evolution/implementations/scripts/reviews_accepted_github.py 9 1 89% 26
/home/slimbook/Escritorio/sources/wg-evolution/implementations/scripts/reviews_github.py 9 1 89% 23
/home/slimbook/Escritorio/sources/wg-evolution/implementations/scripts/utils.py 16 6 62% 38-44
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a few missing tests.