Skip to content

Commit

Permalink
fix signatures
Browse files Browse the repository at this point in the history
Signed-off-by: Sylvain Hellegouarch <sh@defuze.org>
  • Loading branch information
Lawouach committed Nov 7, 2023
1 parent 08e26c8 commit 535904b
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 4 deletions.
10 changes: 9 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,15 @@

## [Unreleased][]

[Unreleased]: https://github.com/chaostoolkit-incubator/chaostoolkit-reliably/compare/0.68.0...HEAD
[Unreleased]: https://github.com/chaostoolkit-incubator/chaostoolkit-reliably/compare/0.68.1...HEAD

## [0.68.1][]

[0.68.1]: https://github.com/chaostoolkit-incubator/chaostoolkit-reliably/compare/0.68.0...0.68.1

### Fixed

* Function signatures in honeycomb vendor

## [0.68.0][]

Expand Down
4 changes: 2 additions & 2 deletions chaosreliably/controls/vendors/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ def apply_vendors(method: str, **kwargs) -> None: # type: ignore
logger.debug(
"failed to apply 'started' method on vendor "
f"class {v.__class__.__name__}",
exc_infp=True,
exc_info=True,
)
elif method == "finished":
try:
Expand All @@ -29,5 +29,5 @@ def apply_vendors(method: str, **kwargs) -> None: # type: ignore
logger.debug(
"failed to apply 'finished' method on vendor "
f"class {v.__class__.__name__}",
exc_infp=True,
exc_info=True,
)
4 changes: 3 additions & 1 deletion chaosreliably/controls/vendors/honeycomb.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,9 @@ def started(
secrets=secrets,
)

def finished(self, journal: Journal) -> None:
def finished(
self, journal: Journal, configuration: Configuration, secrets: Secrets
) -> None:
if not self.experiment_marker:
return None

Expand Down

0 comments on commit 535904b

Please sign in to comment.