Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean-duplicates: escape '+' in filenames #104

Merged
merged 1 commit into from
Apr 8, 2024
Merged

Conversation

xiota
Copy link
Contributor

@xiota xiota commented Jan 26, 2024

chaotic dedup misses filenames containing + because it's a special symbol in grep (Perl/Extended) regular expressions. find seems to work with escaped or unescaped +.

@xiota xiota requested a review from PedroHLC January 27, 2024 01:50
@xiota
Copy link
Contributor Author

xiota commented Feb 2, 2024

@PedroHLC Have you had a chance to look at this?

To see the problem this is intended to solve, run chaotic dedup, then:

$ repoctl status
On repo chaotic-aur

    c++utilities: obsolete(1)

Affected packages:

$ pacman -Ss '\+' | sed 's& .*$&&' | grep '+' | grep '^chaotic-aur'
chaotic-aur/c++utilities
chaotic-aur/foobillard++
chaotic-aur/libstdc++5
chaotic-aur/speedtest++

@PedroHLC
Copy link
Member

PedroHLC commented Feb 2, 2024

@PedroHLC Have you had a chance to look at this?

I did, the thing is that I didn't like when I wrote the original pipe there, so I set myself to rewrite it later, but completely forgot about it, and now I'm considering rewriting it 😅 but still haven't got the chance.

@xiota
Copy link
Contributor Author

xiota commented Apr 8, 2024

Would it be okay to merge while future changes are pending?

(Alternatively, drop and ban any package with a + in its name.)

@PedroHLC PedroHLC merged commit 4f95606 into chaotic-aur:main Apr 8, 2024
1 check passed
@dr460nf1r3
Copy link
Member

Deployed to all builders 🧙

@xiota
Copy link
Contributor Author

xiota commented Apr 8, 2024

Thank you.

dr460nf1r3 added a commit to garuda-linux/infrastructure-nix that referenced this pull request Apr 9, 2024
@xiota xiota deleted the pr_mod branch April 18, 2024 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants