-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support minmax reductions? #14770
Comments
This comment has been minimized.
This comment has been minimized.
(it also could beg the question whether we'd want a |
This comment has been minimized.
This comment has been minimized.
To get you started, I'd suggest looking at modules/internal/ChapelReduce.chpl, look at how the min and MinReduceOp and MaxReduceOp classes are defined, and add a similar class named |
This comment has been minimized.
This comment has been minimized.
Implements feature request in chapel-lang#14770. Returns a 2-tuple with the first element being the corresponding minimum and the second element being the maximum.
Implements feature request in chapel-lang#14770. Returns a 2-tuple with the first element being the corresponding minimum and the second element being the maximum.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
I don't think minmax is a big bottleneck, but I'd still be in favor of getting that into arkouda. Can we just drop in a duplicate minmax class into arkouda and have that take precedence over the builtin one that will be on master, or will that be ambiguous? If it's ambiguous I'd probably just name it |
Implements feature request in #14770. A minmax reduction returns a 2-tuple with the first element being the corresponding minimum and the second element being the maximum. Implemented by @rahulghangas Reviewed and merged by @bradcray @vasslitvinov
Resolved by #15062 |
I believe if it's put into an Arkouda file that's explicitly |
We have min and max reductions, but no way to get both at once. You can get the min and max separately but you end up looking through your array twice. You can optimize this by manually writing the loop yourself, but it's not as clean/simple:
It seems attractive to be able to do something like:
Finding both min and max is a pretty common idiom idiom in arkouda. Reductions are fast enough that I don't think it's a major bottleneck, but it would save some time.
The text was updated successfully, but these errors were encountered: