update libtoml version for mason-external test

[arezaii]

This PR is an attempt to fix sporadic test failures from mason-external.

The change to the version number of the libtomlc99 library is intended
to prevent two tests that use the same library from accessing the
same build space in /tmp/chapelu/spack-stage.

Local testing indicates this may resolve the issue captured in
cray/chapel-private/issues/2648.

TESTING:

• util/start_test test/mason/mason-external passes

Signed-off-by: arezaii ahmad.rezaii@hpe.com

[aconsroe-hpe]

Is there something wrong with libtoml99 0.2019.06.24 that is fixed in the newer version? Or is it just that any different version is needed to not collide with another test (when run in parallel)?

If it is the latter, then it would be interesting to look at whether we can provide some way of separating the two mason paths or locking the dirs or something else.

[bradcray]

then it would be interesting to look at whether we can provide some way of separating the two mason paths or locking the dirs or something else.

My head goes here too since "let's just pick a few distinct versions" feels a little arbitrary. Or "Could we put both tests into the same directory and somehow just install the external package once"? (given that paratest doesn't parallelize within a directory, just across distinct directories).

All that said, I wouldn't object to proceeding with a quick fix like this to quiet testing for the time being given the noise in triage.

[aconsroe-hpe]

No objection to the fix either just to clarify

[arezaii]

Is there something wrong with libtoml99 0.2019.06.24 that is fixed in the newer version?

no, it's just a path collision. In these tests we are only testing mason's ability to pull an external dependency and build the project that requires it.

can provide some way of separating the two mason paths

I had some initial difficulty isolating the build paths within each spack directory, but it should be possible by providing a custom config.yaml file that overrides the build location. https://spack.readthedocs.io/en/latest/config_yaml.html#build-stage

Could we put both tests into the same directory and somehow just install the external package once

I see this as a quick fix to quiet the triage emails, but I want to evaluate if we could use a single mason_home for both these tests, combining them into a single folder may accomplish that, as I believe the distinct folders are sort of arbitrary in this case.