Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in AddressSanitizer docs #19696

Merged
merged 1 commit into from
Apr 27, 2022
Merged

Conversation

ronawho
Copy link
Contributor

@ronawho ronawho commented Apr 22, 2022

Remove old ASAN_OPTIONS setting (mistake from #19545)

While here, loosen an error about needing CHPL_HOST_MEM=cstdlib for
asan testing. This is needed for CHPL_SANITIZE, but not when only
setting CHPL_SANITIZE_EXE=address

Remove old `ASAN_OPTIONS` setting (mistake from 19545)

While here, loosen an error about needing `CHPL_HOST_MEM=cstdlib` for
asan testing. This is needed for `CHPL_SANITIZE`, but not when only
setting `CHPL_SANITIZE_EXE=address`

Signed-off-by: Elliot Ronaghan <ronawho@gmail.com>
Copy link
Member

@bmcdonald3 bmcdonald3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but didn't test anything

@ronawho ronawho merged commit 2971bda into chapel-lang:main Apr 27, 2022
@ronawho ronawho deleted the fix-asan-docs branch April 27, 2022 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants