Deprecate 'Map.these' instead of marking it unstable #21733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, 'Map.these' was marked unstable since we are planning on changing the behavior to yield (const ref, ref) instead of just the keys, but we've decided that a deprecation makes more sense than an unstable mark. Signed-off-by: Ben McDonald <46734217+bmcdonald3@users.noreply.github.com>
Signed-off-by: Ben McDonald <46734217+bmcdonald3@users.noreply.github.com>
Signed-off-by: Ben McDonald <46734217+bmcdonald3@users.noreply.github.com>
lydia-duncan
approved these changes
Mar 2, 2023
Signed-off-by: Ben McDonald <46734217+bmcdonald3@users.noreply.github.com>
bradcray
added a commit
to bradcray/chapel
that referenced
this pull request
Mar 3, 2023
(watch out for those #21x33 PRs, kids!) This fixes a few futures that I must've missed in my last paratest run (prior to paratest running futures by default!) as well as an obvious problem with the test of the bash autocompletion which I'm not sure how it slipped past me. It also fixes an issue from Ben McDonald's chapel-lang#21733 which I happened to notice since he's likely out for the evening. While here, I noticed that an erroneous condition that I'd noted earlier in chapel-lang#21652 has been resolved, probably by chapel-lang#21614 as Michael predicted, so I added a compopts line to lock that behavior in (and removed another that, in retrospect, felt overly paranoid). --- Signed-off-by: Brad Chamberlain <bradcray@users.noreply.github.com>
bradcray
added a commit
that referenced
this pull request
Mar 3, 2023
[trivial, not reviewed] This fixes a few futures that I must've missed in my last paratest run (prior to paratest running futures by default!) as well as an obvious problem with the test of the bash autocompletion which I'm not sure how it slipped past me. It also fixes an issue from Ben McDonald's #21733 which I happened to notice since he's likely out for the evening. While here, I noticed that an erroneous condition that I'd noted earlier in #21652 has been resolved, probably by #21614 as Michael predicted, so I added a compopts line to lock that behavior in (and removed another that, in retrospect, felt overly paranoid).
bmcdonald3
added a commit
that referenced
this pull request
Mar 3, 2023
[ trivial, not reviewed ] 'map.items()' was deprecated in #21733 in favor of zipping over the keys and values, so this updates the protobuf code to follow that recommendation.
bmcdonald3
added a commit
to bmcdonald3/chapel
that referenced
this pull request
Mar 3, 2023
In chapel-lang#21733, I had updated submitted benchmarks rather than updating their good files so that we remember to go and update the submitted files. This PR undoes the changes that were made and updates the good files to reflect the deprecations. Signed-off-by: Ben McDonald <46734217+bmcdonald3@users.noreply.github.com>
bmcdonald3
added a commit
to bmcdonald3/chapel
that referenced
this pull request
Mar 3, 2023
In chapel-lang#21733, I had updated submitted benchmarks rather than updating their good files so that we remember to go and update the submitted files. This PR undoes the changes that were made and updates the good files to reflect the deprecations. Signed-off-by: Ben McDonald <46734217+bmcdonald3@users.noreply.github.com>
bmcdonald3
added a commit
that referenced
this pull request
Mar 6, 2023
In #21733, I had updated submitted benchmarks rather than updating their good files so that we remember to go and update the submitted files. This PR undoes the changes that were made and updates the good files to reflect the deprecations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, 'Map.these' was marked unstable since we are planning on changing the behavior to yield (const ref, ref) instead of just the keys, but we've decided that a deprecation makes more sense than an unstable mark.