Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable abs and sqrt to return a param in more cases #24127

Merged
merged 13 commits into from
Jan 17, 2024
Merged

Enable abs and sqrt to return a param in more cases #24127

merged 13 commits into from
Jan 17, 2024

Commits on Jan 17, 2024

  1. Enable abs on param real/imag to return a param real 

    ---
Signed-off-by: Michael Ferguson <mppf@users.noreply.github.com>
    @mppf
    mppf committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    3183f40 View commit details
    Browse the repository at this point in the history

  2. Add future for abs on param complex returning param 

    ---
Signed-off-by: Michael Ferguson <mppf@users.noreply.github.com>
    @mppf
    mppf committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    0af4387 View commit details
    Browse the repository at this point in the history

  3. Add abs and sqrt primitives 

    ---
Signed-off-by: Michael Ferguson <mppf@users.noreply.github.com>
    @mppf
    mppf committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    299bfdd View commit details
    Browse the repository at this point in the history

  4. Use the new primitive in the param real/imag abs 

    ---
Signed-off-by: Michael Ferguson <mppf@users.noreply.github.com>
    @mppf
    mppf committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    878de96 View commit details
    Browse the repository at this point in the history

  5. Add 'abs' for param complex 

    ---
Signed-off-by: Michael Ferguson <mppf@users.noreply.github.com>
    @mppf
    mppf committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    9a477ad View commit details
    Browse the repository at this point in the history

  6. Enable param sqrt and .re / .im for complex 

    ---
Signed-off-by: Michael Ferguson <mppf@users.noreply.github.com>
    @mppf
    mppf committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    fd3f247 View commit details
    Browse the repository at this point in the history

  7. Clarify complex section of spec 

    ---
Signed-off-by: Michael Ferguson <mppf@users.noreply.github.com>
    @mppf
    mppf committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    9ec8243 View commit details
    Browse the repository at this point in the history

  8. Remove debug code 

    ---
Signed-off-by: Michael Ferguson <mppf@users.noreply.github.com>
    @mppf
    mppf committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    07b80d8 View commit details
    Browse the repository at this point in the history

  9. Add test of .re / .im producing param 

    ---
Signed-off-by: Michael Ferguson <mppf@users.noreply.github.com>
    @mppf
    mppf committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    bcdc4db View commit details
    Browse the repository at this point in the history

  10. Add more testing 

    ---
Signed-off-by: Michael Ferguson <mppf@users.noreply.github.com>
    @mppf
    mppf committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    3940049 View commit details
    Browse the repository at this point in the history

  11. Don't use fsqrt in C++ code 

    The C++ overloading handles the size

---
Signed-off-by: Michael Ferguson <mppf@users.noreply.github.com>
    @mppf
    mppf committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    22a1d3f View commit details
    Browse the repository at this point in the history

  12. Avoid compilation error for sqrt(-1) for tests of nan 

    ---
Signed-off-by: Michael Ferguson <mppf@users.noreply.github.com>
    @mppf
    mppf committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    1aabf9c View commit details
    Browse the repository at this point in the history

  13. Add comments 

    ---
Signed-off-by: Michael Ferguson <mppf@users.noreply.github.com>
    @mppf
    mppf committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    4cf0b5f View commit details
    Browse the repository at this point in the history