-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GSoC] Make LLVM back-end support multiple/space-separated ccflags (Fixes #5510) #5511
Conversation
@mppf: You are the most obvious reviewer for this PR, if you have time to look at it. @coodie: One other thing that this PR should include before being merged is a test that will lock in the working behavior to make sure we don't backslide in the future. Let us know if you need pointers into the Chapel testing system for help on how to do this. |
I like how you put effort to testing even little changes like this :), that's really proffesional. @bradcray I have added locking tests. Please take a look. |
Hi @coodie: If you were to check in this new test separately/first (say at the same time you filed the issue), you would need to include the .future and .bad files as you've prepared them here. Since in this case, they're most likely to be merged at the same time as the fix itself, you can (and should) drop those files from the PR because otherwise our test system will just tell us that the future is passing (an indication that its .future and .bad files should be removed). Put another way, since you'll be filing the fix, it ceases to be a test that will work in the "future" and should work now instead. |
Do you think it requires a full test run, or just for those tests that use ccflags and the llvm back-end? |
I think testing test/release/examples/primers and test/extern/ferguson with CHPL_LLVM=llvm with and without --llvm would be sufficient.
|
I plan to merge this PR on Monday. |
PR contributed by @coodie - thanks!
This fixes #5510. Not a big deal, simply split passed arguments by spaces.
Reviewed by @mppf.
Tested: