Split on commas in CC environment variable for chapel_commits emails #12
Conversation
…mails
We're currently observing that a comma-separated list of email
addresses in the GITHUB_COMMIT_EMAILER_RECIPIENT_CC environment
variable is only sending to the first address rather than all of them,
in spite of the fact that the message header looks as though it
contains all of them using a reasonable format.
This applies a .split(",") to the variable before passing it to the
envelopes initializer to see whether splitting it into a list of
addresses works better.
|
@benharsh , @jhoole : This is fairly superstitious, but may be worth a shot (if you agree). Jenna's setting of the environment variable to include all of our email addresses, comma-separated (as an O365 workaround until we can wrestle with it further) only seems to be sending to the first email on the list and not the others in spite of the fact that the message's header seems to be formatted properly and includes all the addresses. Here, I'm wondering whether calling split() on the comma-separated string to turn it into a list of strings, one per email address, will work better. The documentation for envelopes that Ben found for me over lunch suggested that the cc_addr field could be a list of addresses: http://tomekwojcik.github.io/envelopes/api/envelope.html I have no idea how to test this short of dropping it in and seeing what blows up now that I've gotten it past Travis. I'm also not at all insistent that we try this, but trying to be sensitive to the grumbling about how long these mails have been out. |
|
I think the worst that can happen is that it doesn't work which it's already not doing. |
|
@jhoole: It looks like nothing is still what's happening. Did you receive more mails after this was merged? Anything look weird/different about the Cc: line or the logs? |
|
I'm still getting mails. There's nothing weird looking I can see in the Cc: line, the source view, or the Heroku logs (though the Heroku logs don't show the Cc: line). |
|
Since I'm getting the mails, I'm going to see if I can do something weird in my inbox (forwarding the mails to chapel_commits to chapel_commits to see if it'll accept it once the mail is in outlook already). |
We're currently observing that a comma-separated list of email
addresses in the GITHUB_COMMIT_EMAILER_RECIPIENT_CC environment
variable is only sending to the first address rather than all of them,
in spite of the fact that the message header looks as though it
contains all of them using a reasonable format.
This applies a .split(",") to the variable before passing it to the
envelopes initializer to see whether splitting it into a list of
addresses works better.