Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split on commas in CC environment variable for chapel_commits emails #12

Merged
merged 4 commits into from Jan 17, 2019
Merged

Split on commas in CC environment variable for chapel_commits emails #12

merged 4 commits into from Jan 17, 2019

Commits on Jan 17, 2019

  1. Split based on commas in CC environment variable for chapel_commits e… 

    …mails

We're currently observing that a comma-separated list of email
addresses in the GITHUB_COMMIT_EMAILER_RECIPIENT_CC environment
variable is only sending to the first address rather than all of them,
in spite of the fact that the message header looks as though it
contains all of them using a reasonable format.

This applies a .split(",") to the variable before passing it to the
envelopes initializer to see whether splitting it into a list of
addresses works better.
    Brad Chamberlain committed Jan 17, 2019
    Configuration menu
    Copy the full SHA
    b3fdc71 View commit details
    Browse the repository at this point in the history

  2. Break up long line

    Brad Chamberlain committed Jan 17, 2019
    Configuration menu
    Copy the full SHA
    16ba412 View commit details
    Browse the repository at this point in the history

  3. Getting rid of trailing whitespace

    Brad Chamberlain committed Jan 17, 2019
    Configuration menu
    Copy the full SHA
    b631fa5 View commit details
    Browse the repository at this point in the history

  4. Protect against env var being unset

    Brad Chamberlain committed Jan 17, 2019
    Configuration menu
    Copy the full SHA
    73f0adb View commit details
    Browse the repository at this point in the history