Skip to content
This repository has been archived by the owner on Jun 15, 2023. It is now read-only.

Split params into params and routing options #248

Merged
merged 23 commits into from Nov 28, 2012
Merged

Split params into params and routing options #248

merged 23 commits into from Nov 28, 2012

Commits on Oct 12, 2012

  1. Initial work on allowing options to be passed to backbone navigate fu… 

    …nction.
    Ryan Leckey committed Oct 12, 2012
    Configuration menu
    Copy the full SHA
    1e1e4be View commit details
    Browse the repository at this point in the history

  2. Changed strategy slightly.

    Ryan Leckey committed Oct 12, 2012
    Configuration menu
    Copy the full SHA
    2489c2c View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2012

  1. Added two tests; to test !router:route and !router:changeURL acce… 

    …pting arguments.
    Ryan Leckey committed Oct 15, 2012
    Configuration menu
    Copy the full SHA
    66ff4ac View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2012

  1. A couple more tests added that should cover from inception to backbone.

    Ryan Leckey committed Oct 16, 2012
    Configuration menu
    Copy the full SHA
    d0a5cc1 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2012

  1. Merge branch 'master' of git://github.com/chaplinjs/chaplin into topi… 

    …cs/backbone-options
    Ryan Leckey committed Oct 19, 2012
    Configuration menu
    Copy the full SHA
    c2c0ff7 View commit details
    Browse the repository at this point in the history

  2. Moved non-params-like-things out of params and into options.

    Ryan Leckey committed Oct 19, 2012
    Configuration menu
    Copy the full SHA
    9bacba2 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2012

  1. Small fix so that the !router:route can be invoked with 2 params.

    Ryan Leckey committed Oct 31, 2012
    Configuration menu
    Copy the full SHA
    251f621 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2012

  1. Testing library update

    @molily
    molily committed Nov 5, 2012
    Configuration menu
    Copy the full SHA
    86487cd View commit details
    Browse the repository at this point in the history

  2. The Dispatcher shouldn’t deal with what’s on the options hash

    @molily
    molily committed Nov 5, 2012
    Configuration menu
    Copy the full SHA
    7ca1fcd View commit details
    Browse the repository at this point in the history

  3. Move path from params to routing options

    @molily
    molily committed Nov 5, 2012
    Configuration menu
    Copy the full SHA
    d5e6025 View commit details
    Browse the repository at this point in the history

  4. Remove compatibility, this will be a breaking change 

    Whitelist navigate options in changeURL
Comments
    @molily
    molily committed Nov 5, 2012
    Configuration menu
    Copy the full SHA
    1def31f View commit details
    Browse the repository at this point in the history

  5. Use expect.js more properly (no be.ok, use have.own.property)

    @molily
    molily committed Nov 5, 2012
    Configuration menu
    Copy the full SHA
    cd26caf View commit details
    Browse the repository at this point in the history

  6. Async dispatcher spec for RequireJS 2.1 (https://github.com/jrburke/r… 

    …equirejs/wiki/Upgrading-to-RequireJS-2.1)

Style and consistency changes
    @molily
    molily committed Nov 5, 2012
    Configuration menu
    Copy the full SHA
    7a445c1 View commit details
    Browse the repository at this point in the history

  7. Use a stub to test Backbone.History#navigate calls 

    Simplify changeURL options tests
    @molily
    molily committed Nov 5, 2012
    Configuration menu
    Copy the full SHA
    6ceb224 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'master' into topics/backbone-options

    @molily
    molily committed Nov 5, 2012
    Configuration menu
    Copy the full SHA
    80b6622 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2012

  1. Fix parameters for Controller#redirectTo, !router:route, !startupCont… 

    …roller: add options hash
    @molily
    molily committed Nov 6, 2012
    Configuration menu
    Copy the full SHA
    e87a999 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2012

  1. Adjust controller spec to support routing params 

    Test that redirectTo throws an exception
    @molily
    molily committed Nov 22, 2012
    Configuration menu
    Copy the full SHA
    b302295 View commit details
    Browse the repository at this point in the history

  2. LayoutSpec: 

    Test for routing options on !router:route
Test for protocol-relative URLs
Style changes
    @molily
    molily committed Nov 22, 2012
    Configuration menu
    Copy the full SHA
    b994474 View commit details
    Browse the repository at this point in the history

  3. Router spec: 

    Test routing options more properly
Improve check if Backbone history was stopped
Remove duplicate test, merge into one
Renamed variables for consistency
    @molily
    molily committed Nov 22, 2012
    Configuration menu
    Copy the full SHA
    1d69386 View commit details
    Browse the repository at this point in the history

  4. Testing setup: jQuery update to 1.8.3

    @molily
    molily committed Nov 22, 2012
    Configuration menu
    Copy the full SHA
    9351412 View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2012

  1. Added compatibility with old !router:route signature without options … 

    …again
    @molily
    molily committed Nov 25, 2012
    Configuration menu
    Copy the full SHA
    b1dfed2 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2012

  1. Merge branch 'refs/heads/master' into topics/backbone-options

    @paulmillr
    paulmillr committed Nov 28, 2012
    Configuration menu
    Copy the full SHA
    fb08312 View commit details
    Browse the repository at this point in the history

  2. Fix tests.

    @paulmillr
    paulmillr committed Nov 28, 2012
    Configuration menu
    Copy the full SHA
    dbc5a2f View commit details
    Browse the repository at this point in the history