This repository has been archived by the owner on Jun 15, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #878.
Handled some edge cases with
target
and iframes.Removed hardcoded protocols. Now it handles different ports correctly.
Replaced
jsdom-global
with my-own-stuff becausejsdom
fails to resolve some relative links onabout:blank
andjsdom-global
does not provide a way to set url.jsdom-assign
provides valid and real-world-like urls, cookies etc. And it works onrequire
, w/o closure.