Allow RedisMutex’s locking duration and polling interval to be customizable #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
October 13, 2019 16:14
…izable - Update the configuration file with 2 new customizable fields: locking_duration and polling_internal
…izable - call RedisMutex.with_lock with the customizable polling_interval and locking_duration
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, RedisMutex's
sleepandblockoptions are fixed with these 2 values 0.3 and 2, respectively. When the number of jobs is large, we will frequently get the errorRedisMutex::LockError.I have updated the code and opened this PR to make them customizable based on the number of jobs of a workflow.
Additionally, it also helps to solve this issue #57.